-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#151] Add grid tokens screen in demo app #276
Conversation
b30d5db
to
01278b8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Est-ce que c'est normal que le texte de la page soit aussi petit dans la section listant les tokens ? C'est très peu lisible.
Quelques actions :
- faire une rebase depuis develop, car je m'étonne de voir uploadWebDoc.sh ici
- corriger quelques typos
- ajouter un peu de doc
- du renaming à faire
- investiguer ce problème de taille de texte (cf capture d'écran ci-dessous)
...ore/OUDS/Sources/OUDSTheme/OUDSTheme+SemanticTokens/OUDSTheme+GridSemanticTokensHelper.swift
Outdated
Show resolved
Hide resolved
...ore/OUDS/Sources/OUDSTheme/OUDSTheme+SemanticTokens/OUDSTheme+GridSemanticTokensHelper.swift
Outdated
Show resolved
Hide resolved
...ore/OUDS/Sources/OUDSTheme/OUDSTheme+SemanticTokens/OUDSTheme+GridSemanticTokensHelper.swift
Outdated
Show resolved
Hide resolved
0da12b1
to
3303a32
Compare
… size Class with etracompact category
…ss in environment
5eed149
to
63d5896
Compare
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Encore de fautes de frappes et du mauvais naming.
Le code ne compile pas à cause d'une erreur SwiftLint qui aurait dûe être corrigée.
Pour avancer sur la release je corrige directement.
Note: Please transform
- [ ]
into- (NA)
in the description when things are not applicableRelated issues
Description
Motivation & Context
Types of change
Previews
Checklist
Contribution
Accessibility
Design
Development
Documentation
Checklist (for Core Team only)