Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#151] Add grid tokens screen in demo app #276

Merged
merged 6 commits into from
Nov 14, 2024

Conversation

ludovic35
Copy link
Member

@ludovic35 ludovic35 commented Nov 12, 2024

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

Description

Motivation & Context

Types of change

  • New feature (non-breaking change which adds functionality)

Previews

Checklist

Contribution

Accessibility

  • My change follows accessibility good practices

Design

  • My change respects the design guidelines of Orange Unified Design System

Development

  • My change follows the developer guide
  • I checked my changes do not add new SwiftLint warnings
  • I have added unit tests to cover my changes (optional)

Documentation

  • My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • The evolution have been tested and the project builds for iPhones and iPads
  • Code review has been done by reviewers according to CODEOWNERS file
  • (NA) Design review has been done
  • (NA) Accessibiltiy review has been done
  • (NA) Q/A team has tested the evolution
  • Documentation has been updated if relevant
  • Internal files have been updated if relevant (like CONTRIBUTING, DEVELOP, THIRD_PARTY, CONTRIBUTORS, NOTICE)
  • CHANGELOG has been updated respecting keep a changelog rules and reference the issues
  • The wiki has been updated if needed (optional)

@ludovic35 ludovic35 linked an issue Nov 12, 2024 that may be closed by this pull request
1 task
@ludovic35 ludovic35 marked this pull request as ready for review November 12, 2024 14:30
@pylapp pylapp force-pushed the develop branch 7 times, most recently from b30d5db to 01278b8 Compare November 13, 2024 09:54
@pylapp pylapp self-assigned this Nov 13, 2024
@pylapp pylapp changed the title [#151] Add Grid tokens screen in demo app [#151] Add grid tokens screen in demo app Nov 13, 2024
Copy link
Member

@pylapp pylapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Est-ce que c'est normal que le texte de la page soit aussi petit dans la section listant les tokens ? C'est très peu lisible.

Quelques actions :

  • faire une rebase depuis develop, car je m'étonne de voir uploadWebDoc.sh ici
  • corriger quelques typos
  • ajouter un peu de doc
  • du renaming à faire
  • investiguer ce problème de taille de texte (cf capture d'écran ci-dessous)

151 - text size

CHANGELOG.md Outdated Show resolved Hide resolved
NOTICE.txt Show resolved Hide resolved
OUDS/Core/OUDS/Sources/OUDSUserInterfaceSizeClass.swift Outdated Show resolved Hide resolved
OUDS/Core/OUDS/Sources/OUDSUserInterfaceSizeClass.swift Outdated Show resolved Hide resolved
Showcase/Showcase/Pages/Tokens/Grid/GrisTokenPage.swift Outdated Show resolved Hide resolved
Showcase/Showcase/Pages/Tokens/Grid/GrisTokenPage.swift Outdated Show resolved Hide resolved
@ludovic35 ludovic35 force-pushed the 151-demo-app-add-grid-token-screen branch from 5eed149 to 63d5896 Compare November 13, 2024 15:51
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
Copy link
Member

@pylapp pylapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Encore de fautes de frappes et du mauvais naming.
Le code ne compile pas à cause d'une erreur SwiftLint qui aurait dûe être corrigée.
Pour avancer sur la release je corrige directement.

@pylapp pylapp merged commit 22e215e into develop Nov 14, 2024
4 of 7 checks passed
@pylapp pylapp deleted the 151-demo-app-add-grid-token-screen branch November 14, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Demo App] Add Grid token screen
2 participants