Don't use JsonObject.Merge() in Azure AD Deployment Source (#16841)

OrchardCMS · Oct 7, 2024 · de60815 · de60815
1 parent 52958dc
commit de60815
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 17 deletions.
diff --git a/...rdCore.Modules/OrchardCore.Microsoft.Authentication/Deployment/AzureADDeploymentSource.cs b/...rdCore.Modules/OrchardCore.Microsoft.Authentication/Deployment/AzureADDeploymentSource.cs
@@ -1,4 +1,3 @@
-using System.Text.Json;
 using System.Text.Json.Nodes;
 using OrchardCore.Deployment;
 using OrchardCore.Microsoft.Authentication.Services;
@@ -22,12 +21,12 @@ public async Task ProcessDeploymentStepAsync(DeploymentStep step, DeploymentPlan
             return;
         }
 
-        var settings = await _azureADService.GetSettingsAsync();
+        var azureADSettings = await _azureADService.GetSettingsAsync();
 
-        var obj = new JsonObject { ["name"] = nameof(AzureADSettings) };
-
-        obj.Merge(JObject.FromObject(settings, JOptions.Default));
-
-        result.Steps.Add(obj);
+        result.Steps.Add(new JsonObject
+        {
+            ["name"] = "Settings",
+            [nameof(AzureADSettings)] = JObject.FromObject(azureADSettings),
+        });
     }
 }
diff --git a/src/OrchardCore.Modules/OrchardCore.Microsoft.Authentication/MicrosoftAccountStartup.cs b/src/OrchardCore.Modules/OrchardCore.Microsoft.Authentication/MicrosoftAccountStartup.cs
@@ -32,16 +32,9 @@ public override void ConfigureServices(IServiceCollection services)
         services.AddRecipeExecutionStep<MicrosoftAccountSettingsStep>();
 
         services.AddTransient<IConfigureOptions<MicrosoftAccountSettings>, MicrosoftAccountSettingsConfiguration>();
-
-        // Register the options initializers required by the Microsoft Account Handler.
-        services.TryAddEnumerable(new[]
-        {
-            // Orchard-specific initializers:
-            ServiceDescriptor.Transient<IConfigureOptions<AuthenticationOptions>, MicrosoftAccountOptionsConfiguration>(),
-            ServiceDescriptor.Transient<IConfigureOptions<MicrosoftAccountOptions>, MicrosoftAccountOptionsConfiguration>(),
-            // Built-in initializers:
-            ServiceDescriptor.Transient<IPostConfigureOptions<MicrosoftAccountOptions>, OAuthPostConfigureOptions<MicrosoftAccountOptions, MicrosoftAccountHandler>>()
-        });
+        services.AddTransient<IConfigureOptions<AuthenticationOptions>, MicrosoftAccountOptionsConfiguration>();
+        services.AddTransient<IConfigureOptions<MicrosoftAccountOptions>, MicrosoftAccountOptionsConfiguration>();
+        services.AddTransient<IPostConfigureOptions<MicrosoftAccountOptions>, OAuthPostConfigureOptions<MicrosoftAccountOptions, MicrosoftAccountHandler>>();
     }
 }