Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate JavaScript condition in Layer Rule on save (#12901) #12968

Merged
merged 5 commits into from
Apr 24, 2024
Merged

Validate JavaScript condition in Layer Rule on save (#12901) #12968

merged 5 commits into from
Apr 24, 2024

Commits on Dec 21, 2022

  1. Validate JavaScript condition while saving (#12901)

    @sobotama
    sobotama committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    2448eab View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2024

  1. Update to main

    @sobotama
    sobotama committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    b5ddf55 View commit details
    Browse the repository at this point in the history

  2. Remove unused options, fix SA1005 - Single line comment should begin … 

    …with a space
    @sobotama
    sobotama committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    9a3c08f View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2024

  1. Merge remote-tracking branch 'official/main' into sobotama/javascript… 

    …-condition-validation

# Conflicts:
#	src/OrchardCore.Modules/OrchardCore.Rules/Drivers/JavascriptConditionDisplayDriver.cs
    @Piedone
    Piedone committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    ac4cc50 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2024

  1. Apply suggestions from code review 

    Changed error messages, comment moved to more meaningfull place

Co-authored-by: Zoltán Lehóczky <[email protected]>
    @sobotama @Piedone
    sobotama and Piedone authored Apr 24, 2024
    Configuration menu
    Copy the full SHA
    9e249c2 View commit details
    Browse the repository at this point in the history