Support both Text & HTML in the same email

[hishamco]

/cc @MikeKry

[hishamco]

@Mike4tel could you please try to send via EmailTask all the 3 cases to ensure it was similar to the old behavior. Also, I might add unit tests too

[MikeKry]

@hishamco
Thanks for looking at this. Code looks good and I have tested all 3 scenarios.

Html - OK
Text - OK
"All" (may be renamed to multipart/alternative or something) - Works OK (as seen below). Just one more thing. There is need to have two Body fields - text and html (similar as it was before). Because you need to have different formatting in text and html.

[hishamco]

"All" (may be renamed to multipart/alternative or something)

All or Both make sense to me

There is need to have two Body fields - text and html (similar as it was before). Because you need to have different formatting in text and HTML.

This will revert the changes and let the body TextBody & HtmlBody

[hishamco]

@sebastienros are we fine to add two bodies into the MailMessage or shall we let the sender decide if the body is HTML or Text

One option if we use MailMessageFormat.All is to supply the HTML body and then stripe all the HTML tags to make it fine for the plain-text body. This way we can use a single body instead of two

[Mike4tel]

Just pointing out that only stripping html will not let users format text nicely for plain text.. it is needed for good marketing.

But I can see using stripped html version as another feature just to fight spam filters.

[MikeKry]

Is it possible to merge this one? :)

[hishamco]

We forgot this one :) I will do a final review and then merge

[MikeAlhayek]

@hishamco what is the problem that you are trying to solve? Why would we need All as an enum value?

Maybe we should have an interface for the message like INotificationMessage which we already have. Or something similar

public interface IEmailMessage 
{
    string Message { get; }
    bool IsHtml { get; }
}

[hishamco]

Maybe we should have an interface for the message like INotificationMessage which we already have. Or something similar

I don't think so, the issue was the email can be sent in both formats. In the past we already had IsHtml but it didn't fit anymore, that's why I introduced something similar to the MimiKit mail body

[github-actions]

This pull request has merge conflicts. Please resolve those before requesting a review.

[github-actions]

This pull request has merge conflicts. Please resolve those before requesting a review.

[hishamco]

I will revise this soon

[hishamco]

@MikeKry could you please do one more test if you have time

[github-actions]

This pull request has merge conflicts. Please resolve those before requesting a review.

[github-actions]

This pull request has merge conflicts. Please resolve those before requesting a review.

[MikeAlhayek]

for instructions on how to resolve the merge conflicts due to #16572 please follow the step listed in this comment.

[github-actions]

It seems that this pull request didn't really move for quite a while. Is this something you'd like to revisit any time soon or should we close? Please comment if you'd like to pick it up.

[hishamco]

Seems I need to revisit this soon

[github-actions]

It seems that this pull request didn't really move for quite a while. Is this something you'd like to revisit any time soon or should we close? Please comment if you'd like to pick it up.

[sebastienros]

Just a random idea, why not have two tasks, TextEmailTask and HtmlEmailTask. They can have a base class because some people seem to like these ;) and then special case how to render and edit the value.

And since breaking change is important, the current task could keep being what it does by default.

[gvkries]

Just a random idea, why not have two tasks, TextEmailTask and HtmlEmailTask. They can have a base class because some people seem to like these ;) and then special case how to render and edit the value.

And since breaking change is important, the current task could keep being what it does by default.

I think the main idea here is to have both body types in a single email. Even though it's not that common nowadays, it still is a valid feature IMHO.

[hishamco]

I worked locally on this several days ago to fix the conflict then stopped because I'm sick. Hope to finalize this ASAP

[hishamco]

@MikeKry could please do one more test, this PR takes so long, we need to review it and merge it ASAP