Add GraphQL support to UserPickerField #15389

hyzx86 · 2024-02-22T06:42:38Z

hyzx86 · 2024-02-22T07:00:37Z

src/OrchardCore.Modules/OrchardCore.Users/GraphQL/Startup.cs

@@ -10,6 +10,6 @@ public class Startup : StartupBase
    public override void ConfigureServices(IServiceCollection services)
    {
        services.AddSingleton<ISchemaBuilder, CurrentUserQuery>();
-        services.AddTransient<UserType>();
+        services.AddSingleton<UserType>();


Hi @gvkries ， Do you have any other suggestions on how to reuse this type, which would cause an error if you used Transient lifetime?

Could you help to Review this PR? Thanks!

The UserType is currently only populated by the CurrentUserQuery schema builder. It is not individually registered as a type in GraphQL, so I guess that has to change. I need to think about this...

hyzx86 · 2024-02-22T07:01:36Z

@hishamco Could you help to review this PR? Thanks!

hyzx86 · 2024-02-22T07:05:04Z

Not ready, Not ready, now the type updates will cause an error

hishamco · 2024-02-22T11:40:57Z

We will check once it's ready

hyzx86 · 2024-02-22T15:20:46Z

Now I have a sequence-dependent problem. When I implement UserPickerFieldGrpahType in ContentFields Module , dynamic fields cannot be used because the CustomUserSettings in UserType has not been initialized.

However, if I migrate UserPickerField into the User module, I will also need to migrate all other resources for that field, such as some view files , DispayDrivers and It also includes migration of some data structures, such as UserPickerFieldIndex

hyzx86 · 2024-02-22T17:40:38Z

I updated the 'me' field with the ContentItemInterface

Everything seems normal so far

src/OrchardCore.Modules/OrchardCore.ContentFields/GraphQL/Startup.cs

gvkries · 2024-02-22T18:03:57Z

src/OrchardCore.Modules/OrchardCore.Users/GraphQL/Startup.cs

@@ -10,6 +10,6 @@ public class Startup : StartupBase
    public override void ConfigureServices(IServiceCollection services)
    {
        services.AddSingleton<ISchemaBuilder, CurrentUserQuery>();
-        services.AddTransient<UserType>();
+        services.AddScoped<UserType>();


Are you sure you get the right instance of the UserType in any circumstances? I think we should change the way the UserType is build, what I did within the CurrentUserQuery seems not enough anymore.

Yes, they have the same hash code

… into UserPickerField

hyzx86 · 2024-03-09T05:18:24Z

Hi @gvkries , do you have any other suggestions?

hyzx86 · 2024-03-14T07:37:04Z

Hi @Skrypt ， Can you help to review this PR?

hyzx86 · 2024-03-18T18:18:56Z

fixed: #15540

hyzx86 · 2024-03-18T18:20:36Z

@MikeAlhayek And this PR 🫡

gvkries · 2024-03-19T08:08:20Z

Hi @gvkries , do you have any other suggestions?

Sorry, I didn't have time for this. I take a look as soon as possible.

hyzx86 · 2024-03-19T11:32:22Z

Hi @hishamco , This PR is ready for review.

Piedone · 2024-04-22T11:53:24Z

I see. What confused me is that that PR is supposed to fix #15540 (as indicated in its description), just as this one (as indicated in the issue).

gvkries · 2024-04-22T12:02:48Z

I see. What confused me is that that PR is supposed to fix #15540 (as indicated in its description), just as this one (as indicated in the issue).

Yes, that bug is fixed by both PRs, but this is more about the additional feature 🤗

Piedone · 2024-04-22T12:34:37Z

OK, thanks. I'll review this once #15691 is merged, then.

github-actions · 2024-04-22T20:08:14Z

This pull request has merge conflicts. Please resolve those before requesting a review.

hishamco · 2024-04-22T20:09:42Z

OK, thanks. I'll review this once #15691 is merged, then.

It's merged

Piedone · 2024-04-22T21:46:06Z

Thanks! @hyzx86 please fix the merge conflict and let me know.

gvkries · 2024-04-23T11:23:52Z

...rchardCore.Modules/OrchardCore.ContentFields/GraphQL/Types/UserPickerFieldQueryObjectType.cs

+            Name = nameof(UserPickerField);
+
+            Field<ListGraphType<StringGraphType>, IEnumerable<string>>("userIds")
+                .Description("user ids")


I think all descriptions should be localizable.

Piedone

When addressing review feedback, please adhere to the following:

Please update your pull request according to feedback until it is approved by one of the core team members.
Apply suggested changes directly so the reviewer doesn't have to eyeball the changes. These resolve themselves after applying them, and that's fine.
Don't resolve other conversations so it's easier to track for the reviewer. Then, the reviewer will resolve them.
Feel free to mark conversations that you addressed to keep track of them with an emoji or otherwise, just don't resolve them.
Please keep conversations happening in line comments in those convos, otherwise, communication will be a mess. If you have trouble finding them, see this video.
When you're done addressing all feedback of a review, click "Re-request review" in the top-right corner for each reviewer when you're ready for another round of review, so they know that you're done.

...rchardCore.Modules/OrchardCore.ContentFields/GraphQL/Types/UserPickerFieldQueryObjectType.cs

…s/UserPickerFieldQueryObjectType.cs Co-authored-by: Zoltán Lehóczky <[email protected]>

coderabbitai · 2024-04-24T08:49:42Z

Walkthrough

The recent update enriches the GraphQL module in OrchardCore by incorporating user picker capabilities. This enhancement enables seamless querying of user picker fields through specific GraphQL query types. Users can now retrieve user-related data such as user IDs and user items efficiently. Additionally, the update includes a project reference to OrchardCore.Users for streamlined dependency management.

Changes

File Path	Change Summary
`.../GraphQL/Startup.cs` `.../GraphQL/Types/UserPickerFieldQueryObjectType.cs`	Added registration for `UserPickerField` and `UserPickerFieldQueryObjectType`. Introduced `UserPickerFieldQueryObjectType` for querying user picker fields in GraphQL.
`.../OrchardCore.ContentFields.csproj`	Added `ProjectReference` to `OrchardCore.Users.csproj`.

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 3d6a459 and 5e360be.

Files selected for processing (1)

src/OrchardCore.Modules/OrchardCore.ContentFields/GraphQL/Types/UserPickerFieldQueryObjectType.cs (1 hunks)

Files skipped from review as they are similar to previous changes (1)

src/OrchardCore.Modules/OrchardCore.ContentFields/GraphQL/Types/UserPickerFieldQueryObjectType.cs

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 2

Out of diff range and nitpick comments (1)

src/OrchardCore.Modules/OrchardCore.ContentFields/GraphQL/Types/UserPickerFieldQueryObjectType.cs (1)

25-25: Consider making the description localizable to support multiple languages.

...rchardCore.Modules/OrchardCore.ContentFields/GraphQL/Types/UserPickerFieldQueryObjectType.cs

gvkries

Beside what @Piedone said, LGTM. Whether we want to keep the firstUser field or not is up to you guys, I'm fine with either decission.

...rchardCore.Modules/OrchardCore.ContentFields/GraphQL/Types/UserPickerFieldQueryObjectType.cs

…s/UserPickerFieldQueryObjectType.cs Co-authored-by: Georg von Kries <[email protected]>

Piedone

Great, thank you!

hyzx86 added 2 commits February 22, 2024 14:39

Add UserPickerField

f35d133

Merge branch 'main' into UserPickerField

cb7bdae

hyzx86 changed the title ~~Add UserPickerField GraphQL Type~~ Add Graphql support to UserPickerField and support CustomUserSettings Feb 22, 2024

hyzx86 commented Feb 22, 2024

View reviewed changes

hyzx86 marked this pull request as draft February 22, 2024 07:04

fix query

d85bc64

hyzx86 marked this pull request as ready for review February 22, 2024 17:40

hyzx86 requested a review from gvkries February 22, 2024 17:41

gvkries reviewed Feb 22, 2024

View reviewed changes

src/OrchardCore.Modules/OrchardCore.ContentFields/GraphQL/Startup.cs Outdated Show resolved Hide resolved

gvkries reviewed Feb 22, 2024

View reviewed changes

hyzx86 added 2 commits February 23, 2024 09:58

Merge branch 'UserPickerField' of https://github.com/hyzx86/OrchardCore…

0974367

… into UserPickerField

update dependency

1418b06

github-actions bot mentioned this pull request Mar 1, 2024

Monthly community metrics report for 2024-02-01..2024-02-29 #15430

Closed

hyzx86 mentioned this pull request Mar 5, 2024

About “Owner” and "Author" property #15458

Open

Merge branch 'main' into UserPickerField

52cc64b

hyzx86 mentioned this pull request Mar 18, 2024

The CustomUserSettings in the graphql me field is registered incorrectly #15540

Closed

Merge branch 'main' into UserPickerField

cd0d788

hyzx86 added 2 commits March 19, 2024 23:48

Merge branch 'main' into UserPickerField

c2645ae

Merge branch 'main' into UserPickerField

da29f40

Merge branch 'main' into UserPickerField

c949c59

github-actions bot added the merge conflict label Apr 22, 2024

hishamco requested a review from Piedone April 22, 2024 20:08

Merge branch 'main' into UserPickerField

7b22445

github-actions bot removed the merge conflict label Apr 23, 2024

gvkries reviewed Apr 23, 2024

View reviewed changes

Piedone requested changes Apr 23, 2024

View reviewed changes

hyzx86 and others added 2 commits April 24, 2024 16:49

Update src/OrchardCore.Modules/OrchardCore.ContentFields/GraphQL/Type…

6adcd22

…s/UserPickerFieldQueryObjectType.cs Co-authored-by: Zoltán Lehóczky <[email protected]>

Update src/OrchardCore.Modules/OrchardCore.ContentFields/GraphQL/Type…

2d57d5d

…s/UserPickerFieldQueryObjectType.cs Co-authored-by: Zoltán Lehóczky <[email protected]>

Merge branch 'main' into UserPickerField

7cb2e44

coderabbitai bot reviewed Apr 24, 2024

View reviewed changes

...rchardCore.Modules/OrchardCore.ContentFields/GraphQL/Types/UserPickerFieldQueryObjectType.cs Outdated Show resolved Hide resolved

...rchardCore.Modules/OrchardCore.ContentFields/GraphQL/Types/UserPickerFieldQueryObjectType.cs Outdated Show resolved Hide resolved

fix code

10d3d04

hyzx86 requested review from Piedone and gvkries April 24, 2024 09:49

gvkries approved these changes Apr 24, 2024

View reviewed changes

...rchardCore.Modules/OrchardCore.ContentFields/GraphQL/Types/UserPickerFieldQueryObjectType.cs Outdated Show resolved Hide resolved

hyzx86 and others added 2 commits April 25, 2024 00:47

Update src/OrchardCore.Modules/OrchardCore.ContentFields/GraphQL/Type…

3d6a459

…s/UserPickerFieldQueryObjectType.cs Co-authored-by: Georg von Kries <[email protected]>

remove firstUser field

5e360be

Piedone mentioned this pull request Apr 24, 2024

Set up CodeRabbit for AI code reviews (Lombiq Technologies: OCORE-159) #15813

Merged

Piedone approved these changes Apr 24, 2024

View reviewed changes

Piedone merged commit 08a6771 into OrchardCMS:main Apr 24, 2024
5 checks passed

Piedone changed the title ~~Add Graphql support to UserPickerField and support CustomUserSettings~~ Add GraphQL support to UserPickerField Apr 24, 2024

hishamco mentioned this pull request Apr 30, 2024

Move UserType to OC.Users.Core #15926

Merged

hyzx86 deleted the UserPickerField branch June 13, 2024 06:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add GraphQL support to UserPickerField #15389

Add GraphQL support to UserPickerField #15389

hyzx86 commented Feb 22, 2024

hyzx86 Feb 22, 2024

gvkries Feb 22, 2024

hyzx86 commented Feb 22, 2024

hyzx86 commented Feb 22, 2024

hishamco commented Feb 22, 2024

hyzx86 commented Feb 22, 2024 •

edited

Loading

hyzx86 commented Feb 22, 2024

gvkries Feb 22, 2024

hyzx86 Feb 23, 2024 •

edited

Loading

hyzx86 commented Mar 9, 2024

hyzx86 commented Mar 14, 2024

hyzx86 commented Mar 18, 2024

hyzx86 commented Mar 18, 2024

gvkries commented Mar 19, 2024

hyzx86 commented Mar 19, 2024

Piedone commented Apr 22, 2024

gvkries commented Apr 22, 2024

Piedone commented Apr 22, 2024

github-actions bot commented Apr 22, 2024

hishamco commented Apr 22, 2024

Piedone commented Apr 22, 2024

gvkries Apr 23, 2024

hyzx86 Apr 24, 2024

Piedone left a comment

coderabbitai bot commented Apr 24, 2024 •

edited

Loading

Walkthrough

Changes

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

coderabbitai bot left a comment

gvkries left a comment

Piedone left a comment

Add GraphQL support to UserPickerField #15389

Add GraphQL support to UserPickerField #15389

Conversation

hyzx86 commented Feb 22, 2024

hyzx86 Feb 22, 2024

Choose a reason for hiding this comment

gvkries Feb 22, 2024

Choose a reason for hiding this comment

hyzx86 commented Feb 22, 2024

hyzx86 commented Feb 22, 2024

hishamco commented Feb 22, 2024

hyzx86 commented Feb 22, 2024 • edited Loading

hyzx86 commented Feb 22, 2024

gvkries Feb 22, 2024

Choose a reason for hiding this comment

hyzx86 Feb 23, 2024 • edited Loading

Choose a reason for hiding this comment

hyzx86 commented Mar 9, 2024

hyzx86 commented Mar 14, 2024

hyzx86 commented Mar 18, 2024

hyzx86 commented Mar 18, 2024

gvkries commented Mar 19, 2024

hyzx86 commented Mar 19, 2024

Piedone commented Apr 22, 2024

gvkries commented Apr 22, 2024

Piedone commented Apr 22, 2024

github-actions bot commented Apr 22, 2024

hishamco commented Apr 22, 2024

Piedone commented Apr 22, 2024

gvkries Apr 23, 2024

Choose a reason for hiding this comment

hyzx86 Apr 24, 2024

Choose a reason for hiding this comment

Piedone left a comment

Choose a reason for hiding this comment

coderabbitai bot commented Apr 24, 2024 • edited Loading

Walkthrough

Changes

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

coderabbitai bot left a comment

Choose a reason for hiding this comment

gvkries left a comment

Choose a reason for hiding this comment

Piedone left a comment

Choose a reason for hiding this comment

hyzx86 commented Feb 22, 2024 •

edited

Loading

hyzx86 Feb 23, 2024 •

edited

Loading

coderabbitai bot commented Apr 24, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)