Set image alt attribute to empty string if media text is null or empty #16859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastienros
approved these changes
Oct 9, 2024
MikeAlhayek
requested changes
Oct 9, 2024
| @@ -15,10 +15,11 @@ | |||
| var path = paths[i]; | |||
| var url = Orchard.AssetUrl(path); | |||
| var text = !string.IsNullOrEmpty(mediaTexts.ElementAtOrDefault(i)) ? mediaTexts[i] : path; | |||
| var alt = !string.IsNullOrEmpty(mediaTexts.ElementAtOrDefault(i)) ? mediaTexts[i] : string.Empty; | |||
There was a problem hiding this comment.
Can we move the line 18 in the else block "line 25"?
There was a problem hiding this comment.
It would need to be in the if block on line 22.
There was a problem hiding this comment.
@MikeAlhayek how does 63928d7 look?
There was a problem hiding this comment.
I could move the var text assignment (line 17) to inside the else block now that it isn't used in the if block.
There was a problem hiding this comment.
@DrewBrasher
Yes also please move line 17 "var text" to the else block.
Additionally, please change paths.Any() on line 9 to paths.length > 0
There was a problem hiding this comment.
I made those changes
MikeAlhayek
approved these changes
Oct 10, 2024
src/OrchardCore.Modules/OrchardCore.Media/Views/MediaField.cshtml
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #14382