-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganize the Admin Menu #17112
Open
MikeAlhayek
wants to merge
29
commits into
main
Choose a base branch
from
ma/admin-menu-settings
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,721
−460
Open
Reorganize the Admin Menu #17112
Changes from 23 commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
803216e
Move all settings under "Settings" menu item and add "Tools" in place…
MikeAlhayek 5c63ae5
Merge branch 'main' into ma/admin-menu-settings
MikeAlhayek d505ad1
more organization
MikeAlhayek 2da1ea0
Merge branch 'main' into ma/admin-menu-settings
MikeAlhayek 70f7cce
use PrefixPosition
MikeAlhayek 779e7fc
update NavigationConstants
MikeAlhayek 77dc434
ensure tools come before settings at the end of the menu
MikeAlhayek f27202d
placement
MikeAlhayek 6c0065c
Merge branch 'main' into ma/admin-menu-settings
MikeAlhayek 042d83b
Add a swich for legacy format
MikeAlhayek 94fbe43
fix missed menus
MikeAlhayek a0d7962
group settings
MikeAlhayek 6e753b9
Use Model.Text in the templates
MikeAlhayek 9962424
shorten the switch key
MikeAlhayek 8869d23
don't use icons
MikeAlhayek a0ae2e0
Merge branch 'main' into ma/admin-menu-settings
MikeAlhayek b5fa299
Merge branch 'main' into ma/admin-menu-settings
MikeAlhayek 6e6cdb0
Merge branch 'main' into ma/admin-menu-settings
MikeAlhayek 7c9cd3c
move Content definitions into Design menu
MikeAlhayek dbdd7ff
fix placement of content definitions
MikeAlhayek e514594
move media to root level
MikeAlhayek adde19b
Merge branch 'main' into ma/admin-menu-settings
MikeAlhayek 9a00fc3
update blog theme
MikeAlhayek 9aa6120
Merge branch 'main' into ma/admin-menu-settings
MikeAlhayek ab9b7d4
adding content
MikeAlhayek e8f3514
Merge branch 'main' into ma/admin-menu-settings
MikeAlhayek 995ed06
Use title case
MikeAlhayek ff19ab9
move media options under settings
MikeAlhayek 8960ba7
Merge branch 'main' into ma/admin-menu-settings
MikeAlhayek File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 changes: 14 additions & 3 deletions
17
src/OrchardCore.Modules/OrchardCore.Admin/Views/NavigationItemText-admin.Id.cshtml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,15 @@ | ||
<span class="icon"> | ||
<i class="fa-solid fa-tachometer" aria-hidden="true"></i> | ||
@using OrchardCore.Navigation | ||
|
||
@if (NavigationHelper.UseLegacyFormat()) | ||
{ | ||
<span class="icon"> | ||
<i class="fa-solid fa-tachometer" aria-hidden="true"></i> | ||
</span> | ||
<span class="title">@Model.Text</span> | ||
|
||
return; | ||
} | ||
|
||
<span class="icon icon-none"> | ||
</span> | ||
<span class="title">@T["Admin"]</span> | ||
<span class="title">@Model.Text</span> |
5 changes: 4 additions & 1 deletion
5
...chardCore.Modules/OrchardCore.AdminDashboard/Views/NavigationItemText-dashboard.Id.cshtml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,4 @@ | ||
<span class="icon"><i class="fa-solid fa-tachometer-alt" aria-hidden="true"></i></span><span class="title">@T["Dashboard"]</span> | ||
<span class="icon"> | ||
<i class="fa-solid fa-tachometer-alt" aria-hidden="true"></i> | ||
</span> | ||
<span class="title">@Model.Text</span> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
40 changes: 0 additions & 40 deletions
40
src/OrchardCore.Modules/OrchardCore.AuditTrail/Navigation/AuditTrailSettingsAdminMenu.cs
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 changes: 14 additions & 1 deletion
15
src/OrchardCore.Modules/OrchardCore.AuditTrail/Views/NavigationItemText-audittrail.Id.cshtml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,14 @@ | ||
<span class="icon"><i class="fa-solid fa-history" aria-hidden="true"></i></span><span class="title">@Model.Text</span> | ||
@using OrchardCore.Navigation | ||
|
||
@if (NavigationHelper.UseLegacyFormat()) | ||
{ | ||
<span class="icon"> | ||
<i class="fa-solid fa-history" aria-hidden="true"></i> | ||
</span> | ||
<span class="title">@Model.Text</span> | ||
|
||
return; | ||
} | ||
|
||
<span class="icon icon-none"></span> | ||
<span class="title">@Model.Text</span> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add to the release notes about this PR, as well as how to opt back to the legacy format. The documentation also needs to be combed through for any references to the menu structure, either in written instructions, or images.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Planning to update the docs before merging. Just need to finalize the PR first.