Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show an error message if permission names are not unique #17385

Merged
merged 12 commits into from
Jan 27, 2025
Prev Previous commit
Next Next commit
Register permissions only once.
gvkries committed Jan 21, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit 7f90273a50addeb431517efc43f5d8524101f4a7
Original file line number Diff line number Diff line change
@@ -23,7 +23,10 @@ public sealed class AzureADStartup : StartupBase
{
public override void ConfigureServices(IServiceCollection services)
{
services.AddPermissionProvider<Permissions>();
if (!services.Any(s => s.ImplementationType == typeof(Permissions)))
{
services.AddPermissionProvider<Permissions>();
}

services.AddSingleton<IAzureADService, AzureADService>();
services.AddRecipeExecutionStep<AzureADSettingsStep>();
Original file line number Diff line number Diff line change
@@ -22,7 +22,10 @@ public sealed class MicrosoftAccountStartup : StartupBase
{
public override void ConfigureServices(IServiceCollection services)
{
services.AddPermissionProvider<Permissions>();
if (!services.Any(s => s.ImplementationType == typeof(Permissions)))
{
services.AddPermissionProvider<Permissions>();
}

services.AddSingleton<IMicrosoftAccountService, MicrosoftAccountService>();
services.AddSiteDisplayDriver<MicrosoftAccountSettingsDisplayDriver>();