Remove unnecessary WithCulture() from localizers #17439
Conversation
| @@ -87,16 +87,6 @@ | |||
| </ItemGroup> | |||
| </Target> | |||
|
|
|||
| <Target Name="UpdateModuleAssets" | |||
There was a problem hiding this comment.
Believe it or not, I don't know :), seems JT did is for a reason when there's WithCultures() in the past
There was a problem hiding this comment.
Then perhaps better not to remove it.
There was a problem hiding this comment.
I don't think that's related to the WithCulture in the localization API
There was a problem hiding this comment.
See https://learn.microsoft.com/en-us/visualstudio/msbuild/assignculture-task?view=vs-2022:
Files: Specifies the list of files with embedded culture names to assign a culture to. The task tries to figure out if each file is a culture-specific resource, and if so, what culture. To skip this detection process and force a file to be culture-neutral, set the metadata entry WithCulture to false.
There was a problem hiding this comment.
This change was introduced in #1483, TBH I have never seen such this while working on localization, so I will revert this change and let us move this PR forward
src/OrchardCore/OrchardCore.Module.Targets/OrchardCore.Module.Targets.targets
Outdated
Show resolved
Hide resolved
No description provided.