-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shortcodes refactor #6561
Merged
Merged
Shortcodes refactor #6561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deanmarcussen
commented
Jul 2, 2020
src/OrchardCore.Modules/OrchardCore.Media/Shortcodes/ImageShortcodeProvider.cs
Outdated
Show resolved
Hide resolved
sebastienros
approved these changes
Jul 2, 2020
jtkech
reviewed
Jul 2, 2020
src/OrchardCore.Modules/OrchardCore.Media/Shortcodes/ImageShortcodeProvider.cs
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.Media/Shortcodes/ImageShortcodeProvider.cs
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.Media/Shortcodes/ImageShortcodeProvider.cs
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.Media/Shortcodes/ImageShortcodeProvider.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.Media/Shortcodes/ImageShortcodeProvider.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.Media/Shortcodes/ImageShortcodeProvider.cs
Outdated
Show resolved
Hide resolved
jtkech
reviewed
Jul 6, 2020
src/OrchardCore.Modules/OrchardCore.Media/Shortcodes/ImageShortcodeProvider.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.Shortcodes/Services/ShortcodeService.cs
Outdated
Show resolved
Hide resolved
…tcodeProvider.cs Co-authored-by: Jean-Thierry Kéchichian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #6199
Shortcodes
parser by @sebastienrosShortCode
toShortcodes
as I got it wrong :(The rename includes files, folders, and csproj, so will create a new nuget package name. We did this a while ago with the
Github
toGitHub
change, and it worked ok, so I think is ok to do it.[image]
shortcode using the new parserHas one issue with the
MarkDig
processor which replaces"
which and html encoded version, so arguments have to be used with a single quote, not a double quote.Need to look further into that issue.
Does not include
Wanted to get some progress going however, with the changes that are necesary, and was wanting to implement a
Shortcode
yesterday, but didn't want to because it will be so trivial with the new parser