Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shortcodes refactor #6561

Merged
merged 18 commits into from
Jul 7, 2020
Merged

Shortcodes refactor #6561

merged 18 commits into from
Jul 7, 2020

Conversation

deanmarcussen
Copy link
Member

Related to #6199

  • Implements Shortcodes parser by @sebastienros
  • Renames ShortCode to Shortcodes as I got it wrong :(
    The rename includes files, folders, and csproj, so will create a new nuget package name. We did this a while ago with the Github to GitHub change, and it worked ok, so I think is ok to do it.
  • Renames interfaces, and removes unecesary interfaces
  • Implements the [image] shortcode using the new parser

Has one issue with the MarkDig processor which replaces " which and html encoded version, so arguments have to be used with a single quote, not a double quote.
Need to look further into that issue.

Does not include

  • The shape Shortcode I demoed a week ago, still deciding if that's useful
  • Admin editable Shortcodes. That's for another pr

Wanted to get some progress going however, with the changes that are necesary, and was wanting to implement a Shortcode yesterday, but didn't want to because it will be so trivial with the new parser

@deanmarcussen deanmarcussen merged commit 3f23481 into dev Jul 7, 2020
@delete-merged-branch delete-merged-branch bot deleted the deanmarcussen/shortcodes-rename branch July 7, 2020 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants