Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GenericSortable #25

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from
Open

Conversation

burningice2866
Copy link
Contributor

This pull request lays the foundation for more intuitive sorting of items within the C1 Console, as discussed in this feature request http://compositec1.codeplex.com/workitem/770.

The code is from the C1Contrib.Sorting package, without the UI from drag-n-drop sorting (yet) since i feel this needs some discussion for how it should math the look and feel of the new console.

It refactors the LocalOrdering property from IPageStructure into a new interface which can then be applied to all IData elements. A new "Is sortable" checbox is also exposed when creating and editing dynamic datatypes through the Console and a new textbox for entering the sortorder is added to the Default Form Markup.

… which can be used by developers to add sorting to their own datatypes.

Enabling sorting on dynamicly created datatypes through the C1 Console.
@burningice2866
Copy link
Contributor Author

It was unfortunate that this didn't make it for the 5.0 release, hopefully it can get merged soon so we can get it a upcoming service release.

Do you need more information from me, please don't hesitate to comment or ask away.

napernik and others added 4 commits January 31, 2017 16:41
Fixing issue where Checkbox Form Control fail when added to page afte…
C1 CMS naming and fixes (mostly upgrade related)
@portal7
Copy link

portal7 commented Apr 18, 2017

+1 for this!

@portal7
Copy link

portal7 commented Apr 18, 2017

Works with the current version? ( C1 CMS 6.0 (6.0.6248.33161) )

@burningice2866
Copy link
Contributor Author

@portal7 i see that the Pull Request needs a refresh to be able to merge into newest version, but the package (https://ci.appveyor.com/project/burningice/compositec1contrib/build/artifacts) works with 6.0 and can be installed as a local package.

# Conflicts:
#	Composite.Workflows/Plugins/Elements/ElementProviders/GeneratedDataTypesElementProvider/AddNewInterfaceTypeWorkflow.cs
#	Composite.Workflows/Plugins/Elements/ElementProviders/GeneratedDataTypesElementProvider/EditInterfaceTypeWorkflow.cs
#	Composite/Core/ResourceSystem/LocalizationFiles.cs
#	Composite/Data/DynamicTypes/DataTypeDescriptorFormsHelper.cs
#	Composite/Data/GeneratedTypes/GeneratedTypesHelper.cs
#	Website/Composite/content/forms/Administrative/AddNewInterfaceTypeStep1.xml
#	Website/Composite/content/forms/Administrative/EditInterfaceTypeStep1.xml
#	Website/Composite/localization/Composite.Plugins.GeneratedDataTypesElementProvider.en-us.xml
@burningice2866
Copy link
Contributor Author

@portal7 @mawtex @napernik Pull request updated to match version C1 6.0

@mawtex mawtex changed the base branch from master to dev April 21, 2017 13:34
@mawtex
Copy link
Collaborator

mawtex commented Apr 21, 2017

Without a UI this is not really surfacing any features - it is a bit weird to offer "is sortable" on data types, without actually offering it. We need a UI.

@burningice2866
Copy link
Contributor Author

burningice2866 commented Apr 21, 2017

@mawtex how is this any different than how the Search is implemented, which also doesn't do anything out of the box but requires a custom provider package to be installed to make things light up.

A search UI is already provided by an external package, although i'll be the first to admit that its not super pretty and should be rewritten in React.

@mawtex
Copy link
Collaborator

mawtex commented Apr 21, 2017

@burningice2866 the UI for search is actually in the core - pretty much everything is there (page, data and media indexers etc), with the exception of a concrete integration to a search engine. We have a package for Lucene.NET and installing that lights up the feature in the console. We install this as a default with starter sites, so the end user experience is a fully working search.

We kind of need a UI that allow users to interact with the ordering, for this pr to make sense. Question is if you or someone else (preferably react savvy, as you say) can bring that about.

@burningice2866
Copy link
Contributor Author

burningice2866 commented Apr 21, 2017

@mawtex I didn't compare UI vs NonUI but working vs NonWorking. Even without a Search-provider package you're presented with search-related options when ie. adding fields to a datatype.

So you could install the Sorting UI in a starter site as well. The advantage of this is being able to update the ui out-of-band with releases of the CMS itself.

@mawtex
Copy link
Collaborator

mawtex commented Apr 24, 2017

So you could install the Sorting UI in a starter site as well.

Sure - if you can provide a native looking UI as part of the PR, we have a complete and awesome feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants