add a check for zero address with governanceRebaseOptIn tx

OriginProtocol · Nov 23, 2024 · 4495130 · 4495130
1 parent db2044a
commit 4495130
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 2 deletions.
diff --git a/contracts/contracts/token/OUSD.sol b/contracts/contracts/token/OUSD.sol
@@ -447,6 +447,7 @@ contract OUSD is Governable {
      * @param _account Address of the account.
      */
     function governanceRebaseOptIn(address _account) external onlyGovernor {
+        require(_account != address(0), "Zero address not allowed");
         _rebaseOptIn(_account);
     }
 

diff --git a/contracts/test/token/ousd.js b/contracts/test/token/ousd.js
@@ -399,6 +399,20 @@ describe("Token", function () {
     );
   });
 
+  it("Should allow a governanceRebaseOptIn call", async () => {
+    let { ousd, governor, mockNonRebasing } = fixture;
+    await ousd.connect(governor).governanceRebaseOptIn(mockNonRebasing.address);
+  });
+
+  it("Should not allow a governanceRebaseOptIn of a zero address", async () => {
+    let { ousd, governor } = fixture;
+    await expect(
+      ousd
+        .connect(governor)
+        .governanceRebaseOptIn("0x0000000000000000000000000000000000000000")
+    ).to.be.revertedWith("Zero address not allowed");
+  });
+
   it("Should maintain the correct balances when rebaseOptIn is called from non-rebasing contract", async () => {
     let { ousd, vault, matt, usdc, josh, mockNonRebasing } = fixture;
 
@@ -501,11 +515,11 @@ describe("Token", function () {
 
     const balanceBefore = await ousd.balanceOf(josh.address);
 
-    for (let i = 0; i < 10 ; i++) {
+    for (let i = 0; i < 10; i++) {
       await ousd.connect(josh).rebaseOptOut();
       await ousd.connect(josh).rebaseOptIn();
     }
-    
+
     expect(await ousd.balanceOf(josh.address)).to.equal(balanceBefore);
   });