Balancer Strategy Code Simplification #1851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahthepro
requested review from
sparrowDom,
DanielVF and
naddison36
as code owners
sparrowDom
approved these changes
Oct 4, 2023
| @@ -537,22 +536,30 @@ abstract contract BaseBalancerStrategy is InitializableAbstractStrategy { | |||
| virtual | |||
| returns (uint256) | |||
| { | |||
| IRateProvider rateProvider = poolRateProvidersCache[ | |||
There was a problem hiding this comment.
this function is really nicely simplified!
| /** | ||
| * @notice Caches Pool Assets and their index. These will never change | ||
| * in a strategy. It's `public` because we already have one strategy | ||
| * initialized without this, would make it easier when upgrading it |
There was a problem hiding this comment.
thanks for thinking this through 🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you made a contract change, make sure to complete the checklist below before merging it in master.
Refer to our documentation for more details about contract security best practices.
Contract change checklist: