Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bulk exit and remove validator #2185

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Conversation

naddison36
Copy link
Collaborator

Changes

  • Changed exit and remove validators to be bulk functions so multiple validators can be exited or removed in a single tx

Dependencies

The is to be deployed with

Code Change Checklist

To be completed before internal review begins:

  • The contract code is complete
  • Executable deployment file
  • Fork tests that test after the deployment file runs
  • Unit tests *if needed
  • The owner has done a full checklist review of the code + tests

Internal review:

  • Two approvals by internal reviewers

Copy link

github-actions bot commented Aug 12, 2024

Warnings
⚠️ 👀 This PR needs at least 2 reviewers

Generated by 🚫 dangerJS against a914ea9

Copy link

codecov bot commented Aug 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.88%. Comparing base (082402a) to head (a914ea9).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2185      +/-   ##
==========================================
+ Coverage   60.27%   60.88%   +0.61%     
==========================================
  Files          72       72              
  Lines        3509     3513       +4     
  Branches      685      907     +222     
==========================================
+ Hits         2115     2139      +24     
+ Misses       1391     1371      -20     
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Base automatically changed from nicka/mev-fees to master August 12, 2024 23:37
@naddison36 naddison36 requested a review from clement-ux as a code owner August 19, 2024 10:54
@naddison36 naddison36 mentioned this pull request Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant