Deployed 112 and 113 - Morpho Gauntlet USDC and USDT Strategies for OUSD #2328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naddison36
requested review from
sparrowDom,
DanielVF,
shahthepro and
clement-ux
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2328 +/- ##
==========================================
+ Coverage 52.15% 53.32% +1.17%
==========================================
Files 80 80
Lines 4101 4101
Branches 1079 1079
==========================================
+ Hits 2139 2187 +48
+ Misses 1959 1911 -48
Partials 3 3 ☔ View full report in Codecov by Sentry. |
clement-ux
previously approved these changes
Dec 18, 2024
There was a problem hiding this comment.
- All deployed contracts are listed in the deploy PR's description
- MorphoGauntletPrimeUSDCStrategyProxy
- MorphoGauntletPrimeUSDTStrategyProxy
- Generalized4626Strategy
- Generalized4626USDTStrategy
- Deployed contract's verified code (and all dependencies) match the code in master
- MorphoGauntletPrimeUSDCStrategyProxy
- MorphoGauntletPrimeUSDTStrategyProxy
- Generalized4626Strategy
- Generalized4626USDTStrategy
- Contract constructors have correct arguments
-
MorphoGauntletPrimeUSDCStrategyProxyNo constructor -
MorphoGauntletPrimeUSDTStrategyProxyNo constructor - Generalized4626Strategy:
- 0xdd0f28e19c1780eb6396170735d45153d261490d: Gauntlet USDC Prime (plateform address)
- 0xe75d77b1865ae93c7eaa3040b038d7aa7bc02f70: Vault Proxy (vault address)
- 0xa0b86991c6218b36c1d19d4a2e9eb0ce3606eb48: USDC (assetToken)
- Generalized4626USDTStrategy:
- 0x8cb3649114051ca5119141a34c200d65dc0faa73: Gauntlet USDT Prime (plateform address)
- 0xe75d77b1865ae93c7eaa3040b038d7aa7bc02f70: Vault Proxy (vault address)
- 0xdac17f958d2ee523a2206206994597c13d831ec7: USDT (assetToken)
-
- The transactions that interacted with the newly deployed contract match the deploy script.
- Governance proposal matches the deploy script
Code Diff
- MorphoGauntletPrimeUSDCStrategyProxy
sol2uml diff 0x2B8f37893EE713A4E9fF0cEb79F27539f20a32a1 .,node_modules
(node:3652) ExperimentalWarning: The Fetch API is an experimental feature. This feature could change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
Compared the "MorphoGauntletPrimeUSDCStrategyProxy" contract with address 0x2B8f37893EE713A4E9fF0cEb79F27539f20a32a1 on mainnet
to local files under folders ".,node_modules"
match @openzeppelin/contracts/utils/Address.sol
match contracts/governance/Governable.sol
match contracts/proxies/InitializeGovernedUpgradeabilityProxy.sol
match contracts/proxies/Proxies.sol
- Generalized4626Strategy
sol2uml diff 0xC4368860766F1409BeFfE6713CC170945022dE0A .,node_modules
(node:3712) ExperimentalWarning: The Fetch API is an experimental feature. This feature could change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
Compared the "Generalized4626Strategy" contract with address 0xC4368860766F1409BeFfE6713CC170945022dE0A on mainnet
to local files under folders ".,node_modules"
match @openzeppelin/contracts/token/ERC20/extensions/IERC20Metadata.sol
match @openzeppelin/contracts/token/ERC20/IERC20.sol
match @openzeppelin/contracts/token/ERC20/utils/SafeERC20.sol
match @openzeppelin/contracts/utils/Address.sol
match @openzeppelin/contracts/utils/math/SafeMath.sol
match contracts/governance/Governable.sol
match contracts/interfaces/IBasicToken.sol
match contracts/interfaces/IStrategy.sol
match contracts/interfaces/IVault.sol
match contracts/strategies/Generalized4626Strategy.sol
match contracts/token/OUSD.sol
match contracts/utils/Helpers.sol
match contracts/utils/Initializable.sol
match contracts/utils/InitializableAbstractStrategy.sol
match contracts/utils/InitializableERC20Detailed.sol
match contracts/utils/StableMath.sol
match contracts/vault/VaultStorage.sol
match lib/openzeppelin/interfaces/IERC4626.sol
- MorphoGauntletPrimeUSDTStrategyProxy
sol2uml diff 0xe3ae7C80a1B02Ccd3FB0227773553AEB14e32F26 .,node_modules
(node:3766) ExperimentalWarning: The Fetch API is an experimental feature. This feature could change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
Compared the "MorphoGauntletPrimeUSDTStrategyProxy" contract with address 0xe3ae7C80a1B02Ccd3FB0227773553AEB14e32F26 on mainnet
to local files under folders ".,node_modules"
match @openzeppelin/contracts/utils/Address.sol
match contracts/governance/Governable.sol
match contracts/proxies/InitializeGovernedUpgradeabilityProxy.sol
match contracts/proxies/Proxies.sol
- Generalized4626USDTStrategy
sol2uml diff 0xd7a5997EabF06Ab8F2414A4C5a2470706EC4Baa7 .,node_modules
(node:3811) ExperimentalWarning: The Fetch API is an experimental feature. This feature could change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
Compared the "Generalized4626USDTStrategy" contract with address 0xd7a5997EabF06Ab8F2414A4C5a2470706EC4Baa7 on mainnet
to local files under folders ".,node_modules"
match @openzeppelin/contracts/token/ERC20/extensions/IERC20Metadata.sol
match @openzeppelin/contracts/token/ERC20/IERC20.sol
match @openzeppelin/contracts/token/ERC20/utils/SafeERC20.sol
match @openzeppelin/contracts/utils/Address.sol
match @openzeppelin/contracts/utils/math/SafeMath.sol
match contracts/governance/Governable.sol
match contracts/interfaces/IBasicToken.sol
match contracts/interfaces/IStrategy.sol
match contracts/interfaces/IVault.sol
match contracts/strategies/Generalized4626Strategy.sol
match contracts/strategies/Generalized4626USDTStrategy.sol
match contracts/token/OUSD.sol
match contracts/utils/Helpers.sol
match contracts/utils/Initializable.sol
match contracts/utils/InitializableAbstractStrategy.sol
match contracts/utils/InitializableERC20Detailed.sol
match contracts/utils/StableMath.sol
match contracts/vault/VaultStorage.sol
match lib/openzeppelin/interfaces/IERC4626.sol
shahthepro
previously approved these changes
Dec 18, 2024
There was a problem hiding this comment.
- All deployed contracts are listed in the deploy PR's description
- Deployed contract's verified code (and all dependencies) match the code in master
- Contract constructors have correct arguments
- The transactions that interacted with the newly deployed contract match the deploy script.
- Governance proposal matches the deploy script
- Smoke tests pass after fork test execution of the governance proposal
clement-ux
previously approved these changes
Dec 18, 2024
…to nicka/deploy-morpho-gauntlet
sparrowDom
approved these changes
Dec 19, 2024
There was a problem hiding this comment.
- All deployed contracts are listed in the deploy PR's description
- Deployed contract's verified code (and all dependencies) match the code in master
- Contract constructors have correct arguments
- The transactions that interacted with the newly deployed contract match the deploy script.
- Governance proposal matches the deploy script
- Smoke tests pass after fork test execution of the governance proposal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependencies
Deployment
Deploy scripts
112_ousd_morpho_gauntlet_usdc.js113_ousd_morpho_gauntlet_usdt.jsContracts
Governance
Morpho Gauntlet USDC Strategy
Proposal payload
[ [ "0xE75D77B1865Ae93c7eaa3040B038D7aA7BC02F70", "0x21Fb5812D70B3396880D30e90D9e5C1202266c89", "0x2B8f37893EE713A4E9fF0cEb79F27539f20a32a1" ], [ { "type": "BigNumber", "hex": "0x00" }, { "type": "BigNumber", "hex": "0x00" }, { "type": "BigNumber", "hex": "0x00" } ], [ "approveStrategy(address)", "setSupportedStrategy(address,bool)", "setHarvesterAddress(address)" ], [ "0x0000000000000000000000002b8f37893ee713a4e9ff0ceb79f27539f20a32a1", "0x0000000000000000000000002b8f37893ee713a4e9ff0ceb79f27539f20a32a10000000000000000000000000000000000000000000000000000000000000001", "0x00000000000000000000000021fb5812d70b3396880d30e90d9e5c1202266c89" ] ]Morpho Gauntlet USDT Strategy
Proposal payload
[ [ "0xE75D77B1865Ae93c7eaa3040B038D7aA7BC02F70", "0x21Fb5812D70B3396880D30e90D9e5C1202266c89", "0xe3ae7C80a1B02Ccd3FB0227773553AEB14e32F26" ], [ { "type": "BigNumber", "hex": "0x00" }, { "type": "BigNumber", "hex": "0x00" }, { "type": "BigNumber", "hex": "0x00" } ], [ "approveStrategy(address)", "setSupportedStrategy(address,bool)", "setHarvesterAddress(address)" ], [ "0x000000000000000000000000e3ae7c80a1b02ccd3fb0227773553aeb14e32f26", "0x000000000000000000000000e3ae7c80a1b02ccd3fb0227773553aeb14e32f260000000000000000000000000000000000000000000000000000000000000001", "0x00000000000000000000000021fb5812d70b3396880d30e90d9e5c1202266c89" ] ]Deploy checklist
Two reviewers complete the following checklist: