Skip to content
This repository has been archived by the owner on Sep 20, 2023. It is now read-only.

Thumbnail Generation Service #2187

Open
micahalcorn opened this issue May 1, 2019 · 7 comments
Open

Thumbnail Generation Service #2187

micahalcorn opened this issue May 1, 2019 · 7 comments
Labels
bridge dapp enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed javascript P4 Something to consider, a feature request that we may not pursue ui/ux

Comments

@micahalcorn
Copy link
Member

micahalcorn commented May 1, 2019

Build a service for generating various sizes of images that are added to listings (and profiles?) so that only the optimally-sized image is loaded on small screens, for example.

@micahalcorn micahalcorn added bridge dapp enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed javascript P4 Something to consider, a feature request that we may not pursue ui/ux labels May 1, 2019
@tomlinton
Copy link
Contributor

I think this is a duplicate of #947? I think we ended up deciding against this in the discussion there.

@micahalcorn
Copy link
Member Author

Oh, okay, thanks. I misunderstood. 🙂

@tomlinton
Copy link
Contributor

I don't think you did, it sounded like we wanted to revisit this from the conversation. I mostly wanted to point out the old discussion. :)

Lets leave this one open and close the other one.

@nick
Copy link
Contributor

nick commented Jun 19, 2019

Could be worth considering this as a quick fix:

https://blog.cloudflare.com/announcing-cloudflare-image-resizing-simplifying-optimal-image-delivery/

Edit: I guess it's for premium customers only so maybe not

@nick
Copy link
Contributor

nick commented Oct 1, 2019

I have just experimented with using https://github.com/willnorris/imageproxy which looks like a great solution for this due to its speed and caching flexibility. Took me 5 mins to set up locally and reduced image bandwidth on page 1 of shoporigin.com from 3.6Mb to 460k.

I think we can setup images.originprotocol.com and let the DApp use that to auto-resize and cache images. We could also put a CDN in front of that to further reduce image latency.

cc @franckc @mikeshultz

@franckc
Copy link
Contributor

franckc commented Oct 1, 2019

Cool. Yes, that seems like a nice image resizer http proxy.
I'm sure it would help on low bandwidth connections. Like on mobile.

Though I bet currently our primary DApp performance bottleneck is not pulling images but rather the latency of our graphQL server...

@nick
Copy link
Contributor

nick commented Oct 1, 2019

Yea agree GraphQL server is the biggest cause of latency. The main reason I looked at this again was to help fix #3570 but I think anything that can help reduce bandwidth would be helpful too.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bridge dapp enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed javascript P4 Something to consider, a feature request that we may not pursue ui/ux
Projects
None yet
Development

No branches or pull requests

4 participants