Skip to content
This repository has been archived by the owner on Sep 20, 2023. It is now read-only.

Android System WebView Requirement #3570

Open
micahalcorn opened this issue Sep 30, 2019 · 2 comments
Open

Android System WebView Requirement #3570

micahalcorn opened this issue Sep 30, 2019 · 2 comments
Labels
android bug Something isn't working as intended dapp mobile P2 Small number of users are affected, major cosmetic issue

Comments

@micahalcorn
Copy link
Member

micahalcorn commented Sep 30, 2019

One user of a Huawei Y5 (Android 8.1.0) reported that his app crashes when he attempts to select an image from his gallery during listing creation. He did not report a similar issue during profile creation, although he may have only included a name. @tomlinton suggested that he install Android System WebView, but we haven't heard back.

@franckc thought this was related to #2344, but it may be less of a problem considering there were no complaints about the webview loading.

See also #3325 (probably not related) 🤖


At Origin, we use ZenHub to manage our engineering tasks and product development. Download their browser extension and check out our open workspace at github.com/originprotocol/origin#zenhub.

@micahalcorn micahalcorn added bug Something isn't working as intended dapp mobile android P2 Small number of users are affected, major cosmetic issue labels Sep 30, 2019
@tomlinton
Copy link
Contributor

This is separate from #2344. It is a bug in Chromium that relates to showing large images at smaller sizes, either via CSS or width/height attributes. Because it is in Chromium the crash won't show up in Sentry, but it does show up in Play Console:

signal 5 (SIGTRAP), code 4 (TRAP_HWBKPT)

It is possible that this doesn't happen with the profile image because we resize it before displaying it, and we don't with the listing images. Someone more familiar with the upload/image cropping/resizing will need to comment (@nick, @shahthepro, @sparrowDom). Since it is not in our code the only viable solution we have is to display thumbnails by resizing them rather than using CSS/height/width attributes.

We should be able to reproduce this in a simulator. The reported Android version was 8.1.0. Also @kayyoo23 you should be aware of this bug and see if you can follow up with the user to check if upgrading the system WebView helped.

@nick
Copy link
Contributor

nick commented Oct 1, 2019

Right now I think we resize images to a max of 2,000 px width or height.

We'd need to implement something like #2187 / #947 (which I think we should do anyway for performance reasons) to fix this properly I guess.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
android bug Something isn't working as intended dapp mobile P2 Small number of users are affected, major cosmetic issue
Projects
None yet
Development

No branches or pull requests

3 participants