This repository has been archived by the owner on Sep 20, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 195
[RFC] Issue #36 - add approx price #118
Closed
inkredabull
wants to merge
73
commits into
OriginProtocol:master
from
inkredabull:issue/36-add-approx-price
Closed
[RFC] Issue #36 - add approx price #118
inkredabull
wants to merge
73
commits into
OriginProtocol:master
from
inkredabull:issue/36-add-approx-price
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove fixed height from root container
Ping @wanderingstan - would love to continue making progress just need a little guidance around what's really essential to get this into mergeable state. |
Hey @inkredabull just took a look. Looks like some merge conflicts came up due to other work on Important: Could you re-submit this as a PR against |
Sure @wanderingstan - will rebase against |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#36
@wanderingstan don't know if your culture is to entertain RFC/WIP PRs but here we go...
Checklist:
Description:
Example:
