Continue on error for create-dmg

Oshlack · Mar 3, 2022 · bb328ba · bb328ba
1 parent a9a7c8f
commit bb328ba
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/.github/workflows/pyinstaller.yml b/.github/workflows/pyinstaller.yml
@@ -63,14 +63,16 @@ jobs:
         run: python3 create_macos.py py2app && chmod +x ./dist/Toblerone.app 
 
       - name: Build dmg
+        continue-on-error: true
         run: |
-            cd ./dist/ && create-dmg 'Toblerone.app'
+            cd ./dist/ 
+            create-dmg 'Toblerone.app'
             if [ $? -eq 2 ]; then
                  echo "Passed with code signing error"
                  cp Toberone*dmg Toblerone.dmg 
             else
                  echo "Some other error in create-dmg"
-                 exit 1
+                 rm Toberone*dmg
             fi
       
       - name: Release