chore: Solve errors caused by newer analyzers

src/UpdatR/Domain/Csproj.cs

@@ -217,7 +217,7 @@ private NuGetFramework GetTargetFramework()
         return null;
     }
 
-    private IDictionary<string, NuGetVersion> GetPackages()
+    private Dictionary<string, NuGetVersion> GetPackages()
     {
         var doc = new XmlDocument();
 

src/UpdatR/Domain/DotnetTools.cs

@@ -10,6 +10,8 @@ namespace UpdatR.Domain;
 internal sealed partial class DotnetTools
 {
     private readonly FileInfo _path;
+    private static readonly JsonSerializerOptions s_jsonSerializerOptions =
+        new JsonSerializerOptions(JsonSerializerDefaults.Web) { WriteIndented = true, };
 
     private DotnetTools(FileInfo path)
     {
@@ -178,18 +180,15 @@ out var updateTo
 
         if (!dryRun && project.UpdatedPackages.Any())
         {
-            var json = JsonSerializer.Serialize(
-                config,
-                new JsonSerializerOptions(JsonSerializerDefaults.Web) { WriteIndented = true, }
-            );
+            var json = JsonSerializer.Serialize(config, s_jsonSerializerOptions);
 
             await File.WriteAllTextAsync(Path, json + Environment.NewLine);
         }
 
         return project;
     }
 
-    private IEnumerable<string> GetPackageIds()
+    private List<string> GetPackageIds()
     {
         var tools = new List<string>();
 

tests/UpdatR.UnitTests/GlobalSuppressions.cs

@@ -0,0 +1,14 @@
+// This file is used by Code Analysis to maintain SuppressMessage
+// attributes that are applied to this project.
+// Project-level suppressions either have no target or are given
+// a specific target and scoped to a namespace, type, member, etc.
+
+using System.Diagnostics.CodeAnalysis;
+
+[assembly: SuppressMessage(
+    "Performance",
+    "CA1861:Avoid constant arrays as arguments",
+    Justification = "Not important for unit tests",
+    Scope = "member",
+    Target = "~M:UpdatR.UnitTests.ProjectBuilder.WithDeprecatedPackage(System.String,System.String,System.String,System.Boolean)~UpdatR.UnitTests.ProjectBuilder"
+)]