1. add treatment of new ROOT.RooFit.MaxCalls agrument

OstapHEP · Dec 17, 2022 · 22aa01b · 22aa01b
1 parent dc0da86
commit 22aa01b
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/ReleaseNotes/release_notes.md b/ReleaseNotes/release_notes.md
@@ -10,7 +10,9 @@
   1. some improvements for frame progress bar 
   1. some improvements for frame-based `tree_reduce`
   1. disable new frame-test for old ROOT 
-
+  1. add treatment of new `ROOT.RooFit.MaxCalls` agrument 
+
+
 ## Backward incompatible:  
 
   1. rename some methods for `Ostap::Math::Integrator`

diff --git a/ostap/fitting/fithelpers.py b/ostap/fitting/fithelpers.py
@@ -789,7 +789,7 @@ def parse_args ( self ,  dataset = None , *args , **kwargs ) :
 
                 _args.append   (  ROOT.RooFit.Offset       ( a )  )
 
-            elif kup in ( 'FITOPTIONS' , 'FITOPTION'      ) and \
+            elif kup in ( 'FITOPTIONS' , 'FITOPTION' ) and \
                           isinstance ( a , string_types   ) and root_info < ( 6 , 28 ) :
 
                 _args.append   (  ROOT.RooFit.FitOptions   ( a )  )
@@ -820,6 +820,11 @@ def parse_args ( self ,  dataset = None , *args , **kwargs ) :
 
                 _args.append   (  ROOT.RooFit.Parallelize ( *a ) )
 
+            elif kup in ( 'MAXCALLS' , 'MAXCALL' ) and \
+                     isinstance ( a , integer_types )    and (6,27) <= root_info :
+
+                _args.append   ( ROOT.RooFit.MaxCalls ( a ) ) 
+
             else :
 
                 self.error ( 'parse_args: Unknown/illegal keyword argument: %s/%s, skip it ' % ( k , type ( a ) ) )