Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove nginx rewrite rules, add static and media paths to nginx #76

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MrApplejuice
Copy link
Contributor

@MrApplejuice MrApplejuice commented Jul 24, 2024

Required when babybuddy/babybuddy#852 is merged.
Addresses issue babybuddy/babybuddy#844

I moved the rewrites (not literally but conceptually) into the django middleware in babybuddy/babybuddy#852. The rewrite rules in nginx are gone.

I also added /static and /media path routing to the nginx configuration because ... that is how it is supposed to work in django if I am not mistaken. I am not quite sure how the /static content was served before, but /media content did not seem to be served at all, right?

@OttPeterR
Copy link
Owner

OttPeterR commented Jul 24, 2024

Media was broken before, correct.

Another issue I'm hitting when trying to update to the latest BB version is issues with the rarer architectures, so not amd64 or aarch64, but the other three. According to dockerhub those downloads are pretty rare. But I bring this up because we may have to drop support for those on the next release.

See the build checks that are failing in #73

@MrApplejuice
Copy link
Contributor Author

Hey!

Dropping armv7 and armhf is probably a bit of a bummer. I think that this will drop support for raspberry pi's which, I think are still a quite popular low-cost way of running home assistant...

When quickly checking the logs, it seems that the ninja install fails? That should not be a hard dependency afterall, I think. I think we can work around that, either by installing ninja via a side-channel (and not pip) or by using a different build-toolchain for whatever is trying to use ninja... I can maybe have a look later this week!

@OttPeterR
Copy link
Owner

I'd really appreciate it if you took a look at it. When I last tried it was like playing whack a mole after each error was fixed a new one showed up. But hey it's worth a shot!

As a heads up for your dev testing, the GitHub builds for one of those other architectures (I forget which) can take up to an hour - so put in a change then go do something else for a bit lol

@cdubz
Copy link

cdubz commented Jul 24, 2024

Just chiming in that I’d very much like to avoid dropping support for any archs. Baby Buddy already does some stuff weirdly to ensure support for smaller user bases. I’m traveling for another 1.5 weeks but I can also help look at that aspect when I’m back., if needed.

@MrApplejuice
Copy link
Contributor Author

Hi... sorry for my sudden absence. I got ill, and did spent my time in bed instead of fixing issues. I am back out of bed now, nut need to get going again. Going to be picking this up again now...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants