feat: Forcenew when group_type changes #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, yes LGTM, thanks for the fix :) |
|
Hi Pablo, |
|
Hi :) I just released the v0.8.11 with your fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Thank you for your amazing module !
We recently encountered a problem where a misconfiguration led us to create "Global" Groupes, instead of "Domain Local".
When we corrected the mistake, the module seek a simple value change for the "group_type" attribute, which does not work as Active Directory refuses to convert "Global" to "Domain Local" and vice versa.
I'm proposing this modification, so that the modification of the groupe_type triggers a destroy / create.
I've never touched any module code, so hopefully this is right, thank you in advance for any advice.
Kind regards,