Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update redcap-survey-link-export-oneshot.R #526

Merged
merged 3 commits into from
Aug 12, 2024
Merged

Conversation

jrob95
Copy link
Contributor

@jrob95 jrob95 commented Aug 12, 2024

Previously roxygen comments were seemingly copied from redcap-import-file-oneshot or similar. Have amended to reflect actual use of the function.

@jrob95
Copy link
Contributor Author

jrob95 commented Aug 12, 2024

This was failing test on Nonexistent Record ID due to an error with the expected text, which I fixed, but is now throwing an error for test-users-export.R:47:3 which to be honest, I don't know where to start with.

@wibeasley wibeasley self-assigned this Aug 12, 2024
@wibeasley wibeasley changed the base branch from main to dev August 12, 2024 16:44
@wibeasley wibeasley merged commit 8c75a12 into OuhscBbmc:dev Aug 12, 2024
1 check failed
@wibeasley
Copy link
Member

@jrob95, thanks for fixing & improving this documentation. That test was catching new fields in the user method (see ref #527). The function was still working for users, but the tests are less forgiving.

wibeasley added a commit that referenced this pull request Aug 12, 2024
@jrob95 jrob95 deleted the patch-1 branch August 13, 2024 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants