Feature ::: Android ::: Edge-to-Edge in all Android versions #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # pom.xml
OS-pedrogustavobilro
requested review from
ItsChaceD,
IT-MikeS,
alexgerardojacinto,
OS-ricardomoreirasilva and
OS-martacarlos
and removed request for
a team
|
12 tasks
OS-martacarlos
approved these changes
Nov 26, 2024
alexgerardojacinto
approved these changes
Nov 26, 2024
| @@ -7,5 +7,5 @@ | |||
| <modelVersion>4.0.0</modelVersion> | |||
| <groupId>com.github.outsystems</groupId> | |||
| <artifactId>osbarcode-android</artifactId> | |||
| <version>1.1.5</version> | |||
| <version>1.2.0-dev1</version> | |||
There was a problem hiding this comment.
I wonder if the version should be 1.1.6 instead of 1.2.0 since this is not exactly a feature we're adding.
There was a problem hiding this comment.
Understood, it is a small change. I was going off of inappbrowser plugin that had a minor version update over a similar change.
There was a problem hiding this comment.
Oh ok. It's not super important either way. It technically isn't a fix but rather a "feature" so we can actually raise the minor version.
alexgerardojacinto
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The barcode library has edge-to-edge working on Android 15 (#37).
This PR adds the same support for other Android versions, to have consistency and also improved UI.
Context
Reference: https://outsystemsrd.atlassian.net/wiki/spaces/RDME/pages/4426137659/iOS+18+Android+15+Assessment
Type of changes
Platforms affected
Tests
Tested Barcode Sample app on different Android versions and screen sizes, to confirm that edge-to-edge is working.
Screenshots (if appropriate)
Checklist
RNMT-XXXX <title>