Ignore property access when view is unloaded #202
Conversation
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) ✅ code/snyk check is complete. No issues have been found. (View Details) |
| @@ -64,7 +64,7 @@ export function loadPlugins(plugins: any[][], frameName: string): void { | |||
|
|
|||
| view = tryGetView(frameName)!; | |||
| if (!view) { | |||
| return; // was probably unloaded | |||
| return; // view was probably unloaded | |||
There was a problem hiding this comment.
following the same strategy that we already have on load
| @@ -10,7 +16,10 @@ export function createPropertiesProxy(rootElement: Element, objProperties: {}, n | |||
| } else { | |||
| proxy[key] = async function () { | |||
| const nativeObject = window[nativeObjName] || await bindNativeObject(nativeObjName); | |||
|
|
|||
| if (!nativeObject && !isViewLoaded?.()) { | |||
| return; // view was probably unloaded | |||
There was a problem hiding this comment.
by returning undefined, we are moving errors to the views, which may then seem weird as in this.props.getSomething() will return undefined.
But the view should be protected from the possibility of props returning undefined.
If the props is void, then all good and we avoid the crash
There was a problem hiding this comment.
just found out that the view is loaded and exists, but the nativeObject does not. I was trying to be less permissive, but i'm wondering now if I can just return if the nativeObject is not defined
No description provided.