Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROU-11403: Enabling accessibility styling for Virtual Select #1005

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

OS-pedrolourenco
Copy link
Contributor

@OS-pedrolourenco OS-pedrolourenco commented Dec 13, 2024

This PR is for...

Sample page

What was happening

Accessibility styling was not being applied to Virtual Select's Dropbox since it is not present inside of the layout element, which in turn holds the accessibility class.

What was done

  • The accessibility class has been added to the dropbox if also present on the layout
  • Focus styling changed from the toggle-all-button to the toggle-all-checkbox
  • Fixed Dropbox options' focus outline

Test Steps

Screenshots

(prefer animated gif)

Checklist

  • tested locally
  • documented the code
  • clean all warnings and errors of eslint
  • requires changes in OutSystems (if so, provide a module with changes)
  • requires new sample page in OutSystems (if so, provide a module with changes)

@OS-pedrolourenco OS-pedrolourenco requested a review from a team as a code owner December 13, 2024 15:42
@BenOsodrac
Copy link
Contributor

@OS-pedrolourenco the tests failed, please double-check if its something related to this or any flaky test, etc.

@OS-pedrolourenco OS-pedrolourenco merged commit db2d443 into dev Dec 18, 2024
13 of 15 checks passed
@OS-pedrolourenco OS-pedrolourenco deleted the ROU-11403-v2 branch December 18, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants