Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROU-4647: Tabs - TabIndex leave current tabs #858

Merged
merged 3 commits into from
Nov 14, 2023
Merged

Conversation

OS-giulianasilva
Copy link
Contributor

This PR is for fixing the Tab focusing on the input of the previous Tab when using TabKey to navigate.

What was happening

  • When setting the tabIndex of the focusable elements inside the inactive and active Tabs, some inputs such as datetime, date and time were not being reached.
  • Because of that, when using the tab key to navigate from the Tab Header to the Tab Content, the input of the previous Tab Content was being focused.

What was done

  • Edited the string used to get all the focusable elements in OSFramework.Helper.Dom.GetFocusableElements

Test Steps

  1. Go to a page with inputs of the type date, datetime, and time inside Tabs.
  2. For all the Tabs, check that it is not possible to reach the previous Tab's content using the Tab key.

Checklist

  • tested locally
  • documented the code
  • clean all warnings and errors of eslint
  • requires changes in OutSystems (if so, provide a module with changes)
  • requires new sample page in OutSystems (if so, provide a module with changes)

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@OS-giulianasilva OS-giulianasilva merged commit bafa9c5 into dev Nov 14, 2023
7 checks passed
@OS-giulianasilva OS-giulianasilva deleted the ROU-4647 branch November 14, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants