This repository has been archived by the owner on Aug 31, 2019. It is now read-only.
Add enforcement of @Console, update dependencies, bump version to 0.4.1-SNAPSHOT #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also tagged all of the versions, but I'm not sure if the tags will carry over if this gets pulled. |
|
@rmsy can you redo this PR on master? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
@Consoleannotation was previously not enforced (allowing the console to execute commands not annotated with@Console), so I added a check in the Bukkit module. I also updated some dependencies, and bumped the version to 0.4.1-SNAPSHOT, to represent the fix.(Note: I'm not sure why I re-committed @Anxuiz's commit, and I don't know how to un-do that.)
Not yet working, I'm re-doing this PR.