Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Url fixes for multi repo switch #136

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Url fixes for multi repo switch #136

merged 1 commit into from
Jan 17, 2024

Conversation

alasdairwilson
Copy link
Collaborator

Mistakenly did not fix the nav bar links, the github links and the links in commentthreads .

The annoyance with the last one is that without doing a database migration the urls in current commentthreads will no longer work, as they will be missing the repoId.

Copy link
Contributor

@martinjrobins martinjrobins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. I don't think we have to worry about the old commenthreads having an incorrect url.

@martinjrobins martinjrobins merged commit 08f332b into main Jan 17, 2024
3 checks passed
@martinjrobins martinjrobins deleted the urls-for-multi-repo branch January 17, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants