Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CMake cannot find 'oxidd_ffi' target #14

Closed
wants to merge 1 commit into from

Conversation

SSoelvsten
Copy link

With 70d6d82 , the 'oxidd-ffi' target was treated as if renamed to 'oxidd_ffi' even though 'corrosion_import_crate' still creates said target with the previous name.

With 70d6d82 , the 'oxidd-ffi' target was treated as if renamed 
to 'oxidd_ffi' even though 'corrosion_import_crate' still creates
said target with the previous name.
@nhusung
Copy link
Member

nhusung commented May 27, 2024

The solution is a different one: As discussed in corrosion-rs/corrosion#501, target names will change in Rust 1.79 to not have dashes but underscores. On its own, the respective change in OxiDD does not break anything as long as you use oxidd in CMake (and not oxidd-ffi, or now oxidd_ffi) to refer to the library. The problem in BDD Benchmark is that we also use lib-bdd-ffi, which also depends on Corrosion but used v4.x while I recently updated to Corrosion v5.0 here. Somehow, different Corrosion versions interfere with each other. Yesterday, I also updated lib-bdd-ffi to Corrosion v5.0, so now it works again. Just merge SSoelvsten/bdd-benchmark#121 to update the libraries :)

@nhusung nhusung closed this May 27, 2024
@SSoelvsten
Copy link
Author

Thanks!

@SSoelvsten SSoelvsten deleted the patch-1 branch May 30, 2024 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants