Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for MySQL 8+ for .NET Framework 4.6+ and remove local MySql.Data dependency #4

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

DezLife
Copy link

@DezLife DezLife commented Jul 22, 2024

  • Added support for MySQL.Data 8.0.32 for .NET Framework 4.6 and above.
  • Removed local MySql.Data reference in favor of NuGet package.
  • Maintained compatibility with older .NET Framework versions using MySQL.Data 6.9.12.

- Removed local MySql.Data reference in favor of NuGet package.
- Maintained compatibility with older .NET Framework versions using MySQL.Data 6.9.12.
@SkiTee3000
Copy link

Newer versions are now available, why 8.0.32 specifically?
image

@DezLife
Copy link
Author

DezLife commented Jul 30, 2024

Newer versions are now available, why 8.0.32 specifically? image

Because this version is stable and more tested. Thus, we can definitely understand that we will not have problems with this.

@DezLife
Copy link
Author

DezLife commented Jul 30, 2024

In any case, if you have time to test newer versions, you can do so.

@SkiTee3000
Copy link

Ok, but I'd prefer 8.4.
@MrBlue, will this be accepted in the current update?

@Lorenzo-oo
Copy link

Lorenzo-oo commented Nov 2, 2024

backward compatibility test for existing plugins with PR on Oxide.MySql.dll
This is to test if updating Oxide.MySql.dll will break existing installation using mySQL 5.7

compiled DezLife PR (MySQL8) and replaced in .\RustDedicated_Data\Managed
using MySQL 5.7

Tested plugin:
MySQLWhitelist. Compile and run without issue, Kick if player is not in whitelist database
KillRecords Compile and run without issue. Database updated whith kill records ("UseSQL": true, "FileType": 1)
PlayerDatabase + PlayerInformation Compile and run without issue. Database updates

@DezLife
Copy link
Author

DezLife commented Nov 2, 2024

backward compatibility test for existing plugins with PR on Oxide.MySql.dll This is to test if updating Oxide.MySql.dll will break existing installation using mySQL 5.7

compiled DezLife PR (MySQL8) and replaced in .\RustDedicated_Data\Managed using MySQL 5.7

Tested plugin: MySQLWhitelist. Compile and run without issue, Kick if player is not in whitelist database KillRecords Compile and run without issue. Database updated whith kill records ("UseSQL": true, "FileType": 1) PlayerDatabase + PlayerInformation Compile and run without issue. Database updates

Thank you for taking the time to check it out!
I appreciate it.

@Lorenzo-oo
Copy link

Lorenzo-oo commented Nov 13, 2024

In server log:
Trying to load assembly: Google.Protobuf
Trying to load assembly: ZstdNet
Are these file needed. does not seem to affect backward compatibility when missing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants