Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More performant o.plugins #487

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Conversation

Tryhard999
Copy link

Reduced allocations and overheard from running the O.plugins command, useful for RCON tools and such that might run it often

@MrBlue
Copy link
Member

MrBlue commented Jan 29, 2024

I'm not opposed to changing the way this command works but I feel like we can make it a little bit more readable and clean it up using StringBuilder.AppendFormat for example:

output.AppendLine();
output.AppendFormat(string.Format("  {0} \"{1}\" ({2}) by {3} ({4}s) - {5}", pluginCount++.ToString("00"), plugin.Title, plugin.Version, plugin.Author, plugin.TotalHookTime.ToString("0.00"), plugin.Filename.Basename()));

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants