Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Oztechan/CCC#3444] Add logging to API and Database layers #3452

Merged
merged 1 commit into from
May 20, 2024

Conversation

mustafaozhan
Copy link
Member

Resolves #3444

@mustafaozhan mustafaozhan requested a review from a team as a code owner May 18, 2024 15:10
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-21.70% 72.73%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (e8097ef) 6270 4742 75.63%
Head commit (08ad1c1) 9442 (+3172) 5092 (+350) 53.93% (-21.70%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#3452) 11 8 72.73%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

Copy link

codecov bot commented May 18, 2024

Codecov Report

Attention: Patch coverage is 37.50000% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 77.31%. Comparing base (e8097ef) to head (08ad1c1).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3452      +/-   ##
===========================================
- Coverage    77.41%   77.31%   -0.10%     
===========================================
  Files          210      210              
  Lines         5896     5901       +5     
  Branches       483      487       +4     
===========================================
- Hits          4564     4562       -2     
- Misses        1295     1296       +1     
- Partials        37       43       +6     

Impacted file tree graph

Files Coverage Δ
...ccc/common/core/network/base/BaseNetworkService.kt 89.47% <50.00%> (-10.53%) ⬇️
.../ccc/common/core/database/base/BaseDBDataSource.kt 69.23% <25.00%> (-12.59%) ⬇️

... and 2 files with indirect coverage changes

Copy link

@mustafaozhan mustafaozhan merged commit a65351e into develop May 20, 2024
16 checks passed
@mustafaozhan mustafaozhan deleted the 3444--Add-logging-to-API-and-Database-layers branch May 20, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add logging to API and Database layers
1 participant