Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Oztechan/CCC#3935] Move onBaseChanged into base observation #3936

Merged
merged 2 commits into from
Sep 15, 2024

Conversation

mustafaozhan
Copy link
Member

Resolves #3935

@mustafaozhan mustafaozhan requested a review from a team as a code owner September 15, 2024 09:38
@mustafaozhan mustafaozhan force-pushed the 3935-Move-onBaseChanged-into-base-observation branch from 3c006b9 to 05ea727 Compare September 15, 2024 09:38
@mustafaozhan mustafaozhan merged commit 231dbf6 into develop Sep 15, 2024
5 checks passed
@mustafaozhan mustafaozhan deleted the 3935-Move-onBaseChanged-into-base-observation branch September 15, 2024 09:38
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.03% 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (03d1aa0) 3238 1736 53.61%
Head commit (05ea727) 3236 (-2) 1734 (-2) 53.58% (-0.03%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#3936) 8 8 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Sep 15, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 57.22%. Comparing base (03d1aa0) to head (05ea727).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...client/viewmodel/calculator/CalculatorViewModel.kt 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3936      +/-   ##
===========================================
- Coverage    57.25%   57.22%   -0.03%     
===========================================
  Files          167      167              
  Lines         2917     2915       -2     
  Branches       436      436              
===========================================
- Hits          1670     1668       -2     
  Misses        1222     1222              
  Partials        25       25              

Impacted file tree graph

Files with missing lines Coverage Δ
...client/viewmodel/calculator/CalculatorViewModel.kt 99.29% <87.50%> (-0.01%) ⬇️

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move onBaseChanged into base observation
1 participant