Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Oztechan/CCC#3985] Refactor Routes with non returning methods #3989

Merged
merged 2 commits into from
Sep 27, 2024

Conversation

mustafaozhan
Copy link
Member

Resolves #3985

@mustafaozhan mustafaozhan requested a review from a team as a code owner September 26, 2024 20:21
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% 0.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (7c41414) 3239 1734 53.54%
Head commit (a1f893a) 3239 (+0) 1734 (+0) 53.54% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#3989) 30 0 0.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 30 lines in your changes missing coverage. Please review.

Project coverage is 57.14%. Comparing base (7c41414) to head (a1f893a).
Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
...m/oztechan/ccc/backend/app/routes/CurrencyRoute.kt 0.00% 8 Missing ⚠️
.../com/oztechan/ccc/backend/app/routes/ErrorRoute.kt 0.00% 8 Missing ⚠️
...n/com/oztechan/ccc/backend/app/routes/RootRoute.kt 0.00% 8 Missing ⚠️
...om/oztechan/ccc/backend/app/routes/VersionRoute.kt 0.00% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3989   +/-   ##
========================================
  Coverage    57.14%   57.14%           
========================================
  Files          167      167           
  Lines         2919     2919           
  Branches       435      435           
========================================
  Hits          1668     1668           
  Misses        1226     1226           
  Partials        25       25           

Impacted file tree graph

Files with missing lines Coverage Δ
...om/oztechan/ccc/backend/app/routes/VersionRoute.kt 0.00% <0.00%> (ø)
...m/oztechan/ccc/backend/app/routes/CurrencyRoute.kt 0.00% <0.00%> (ø)
.../com/oztechan/ccc/backend/app/routes/ErrorRoute.kt 0.00% <0.00%> (ø)
...n/com/oztechan/ccc/backend/app/routes/RootRoute.kt 0.00% <0.00%> (ø)

Copy link

@mustafaozhan mustafaozhan merged commit 51affcd into develop Sep 27, 2024
14 checks passed
@mustafaozhan mustafaozhan deleted the 3985-Refactor-Routes-with-non-returning-methods branch September 27, 2024 10:09
mustafaozhan added a commit that referenced this pull request Sep 30, 2024
* [#1457] Update mokoResources to v0.24.3 (#3975)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Mustafa Ozhan <[email protected]>

* [#1457] Update lifecycle to v2.8.6 (#3967)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Mustafa Ozhan <[email protected]>

* [#1457] Update dependency com.lemonappdev:konsist to v0.16.1 (#3840)

* [#1457] Update dependency com.lemonappdev:konsist to v0.16.1

Co-authored-by: Mustafa Ozhan <[email protected]>

* [#1457] Update dependency com.lemonappdev:konsist to v0.16.1

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Mustafa Ozhan <[email protected]>

* [#1457] Update koin to v4 (major) (#3956)

* [#1457] Update koin to v4

Co-authored-by: Mustafa Ozhan <[email protected]>

* [#1457] Update koin to v4

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Mustafa Ozhan <[email protected]>

* [#1457] Update navigation to v2.8.1 (#3968)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Mustafa Ozhan <[email protected]>

* [#1457] Update dependency com.russhwolf:multiplatform-settings to v1.2.0 (#3849)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Mustafa Ozhan <[email protected]>

* [#1457] Update submodule/basemob digest to 530a6b0 (#3977)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Mustafa Ozhan <[email protected]>

* [#1457] Update dependency com.huawei.hms:ads-prime to v3.4.74.302 (#3974)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Mustafa Ozhan <[email protected]>

* [#3979] Open 80 port for backend app (#3981)

* [#3979] Open 80 port for backend app

* [#3979] Open 80 port for backend app

* [#3980] Remove suspends from ktor methods (#3982)

* [#3983] Get rid of unsafe version read (#3984)

* [#1457] Update actions/checkout action to v4.2.0 (#3978)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Mustafa Ozhan <[email protected]>

* [#1457] Update submodule/logmob digest to 1cb3e43 (#3986)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Mustafa Ozhan <[email protected]>

* [#3985] Refactor Routes with non returning methods (#3989)

* [#3985] Refactor Routes with non returning methods

* [#3985] Refactor Routes with non returning methods

* [#1457] Update dependency ubuntu to v24 (#3988)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Mustafa Ozhan <[email protected]>

* [#1457] Update Oztechan/Global digest to 0d56c9a

Co-authored-by: Mustafa Ozhan <[email protected]>

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Mustafa Ozhan <[email protected]>
mustafaozhan added a commit that referenced this pull request Sep 30, 2024
* [#1457] Update dependency gradle to v8.10.2

Co-authored-by: Mustafa Ozhan <[email protected]>

* [#1457] Update Oztechan/Global digest to 0d56c9a (#3990)

* [#1457] Update mokoResources to v0.24.3 (#3975)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Mustafa Ozhan <[email protected]>

* [#1457] Update lifecycle to v2.8.6 (#3967)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Mustafa Ozhan <[email protected]>

* [#1457] Update dependency com.lemonappdev:konsist to v0.16.1 (#3840)

* [#1457] Update dependency com.lemonappdev:konsist to v0.16.1

Co-authored-by: Mustafa Ozhan <[email protected]>

* [#1457] Update dependency com.lemonappdev:konsist to v0.16.1

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Mustafa Ozhan <[email protected]>

* [#1457] Update koin to v4 (major) (#3956)

* [#1457] Update koin to v4

Co-authored-by: Mustafa Ozhan <[email protected]>

* [#1457] Update koin to v4

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Mustafa Ozhan <[email protected]>

* [#1457] Update navigation to v2.8.1 (#3968)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Mustafa Ozhan <[email protected]>

* [#1457] Update dependency com.russhwolf:multiplatform-settings to v1.2.0 (#3849)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Mustafa Ozhan <[email protected]>

* [#1457] Update submodule/basemob digest to 530a6b0 (#3977)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Mustafa Ozhan <[email protected]>

* [#1457] Update dependency com.huawei.hms:ads-prime to v3.4.74.302 (#3974)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Mustafa Ozhan <[email protected]>

* [#3979] Open 80 port for backend app (#3981)

* [#3979] Open 80 port for backend app

* [#3979] Open 80 port for backend app

* [#3980] Remove suspends from ktor methods (#3982)

* [#3983] Get rid of unsafe version read (#3984)

* [#1457] Update actions/checkout action to v4.2.0 (#3978)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Mustafa Ozhan <[email protected]>

* [#1457] Update submodule/logmob digest to 1cb3e43 (#3986)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Mustafa Ozhan <[email protected]>

* [#3985] Refactor Routes with non returning methods (#3989)

* [#3985] Refactor Routes with non returning methods

* [#3985] Refactor Routes with non returning methods

* [#1457] Update dependency ubuntu to v24 (#3988)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Mustafa Ozhan <[email protected]>

* [#1457] Update Oztechan/Global digest to 0d56c9a

Co-authored-by: Mustafa Ozhan <[email protected]>

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Mustafa Ozhan <[email protected]>

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Mustafa Ozhan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor Routes with non returning methods
1 participant