Skip to content

Commit

Permalink
Merge remote-tracking branch 'lawnicons/develop' into shinka
Browse files Browse the repository at this point in the history
  • Loading branch information
project404bot committed Sep 15, 2024
2 parents 562b7a3 + aee22ea commit 0ea79ea
Show file tree
Hide file tree
Showing 222 changed files with 2,371 additions and 970 deletions.
4 changes: 2 additions & 2 deletions .github/ISSUE_TEMPLATE/config.yml
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
blank_issues_enabled: false
contact_links:
- name: Link apps to existing icons
- name: Link apps to identical icons
url: https://github.com/LawnchairLauncher/lawnicons/blob/develop/CONTRIBUTING.md#adding-an-icon-to-lawnicons
about: Learn more about linking an app to an existing icon and making a PR to contribute to Lawnicons.
about: Learn more about linking an app to an existing icon via a pull request.
- name: Icon Request
url: https://forms.gle/xt7sJhgWEasuo9TR9
about: Please request your icons in this form.
6 changes: 1 addition & 5 deletions .github/icon_checklist.md
Original file line number Diff line number Diff line change
@@ -1,26 +1,22 @@
Thanks for your contribution!

While waiting for a review from our team, you can do a self-review to ensure that your icons are suitable for Lawnicons.
While waiting for a review from our team, you can do a self-review to ensure that your icons are suitable for Lawnicons. We try to do the review within 7 days.

### Canvas and sizes
1. Canvas: `192×192px`.
2. Non-square icons: the long side of the icons should be `160px`.
3. Square icons: `154×154px`.
- [ ] Approved by the Lawnicons reviewer
### Color, stroke width and rounding
1. Color: non-transparent black `#000`.
2. No fill. Base stroke width: `12px`. `14px`, `10px`, `8px` — depending on the shape of the icons. `6px` — for fine details.
3. Rounded ends and joins. 90° corners are rounded by `6-32px`.
- [ ] Approved by the Lawnicons reviewer
### Naming
1. Names should match the official app name and contain no additional text.
2. If the first `3` characters of the app name contain letters not from the English alphabet, then add a localized (or transliterated) name via `~~`. Example: `京东 ~~ JD`.
3. The names of the drawables should repeat the names of the apps if nothing prevents it.
- [ ] Approved by the Lawnicons reviewer
### Quality
1. Ensure that icons are easily recognizable.
2. Align icons to [the visual center](https://crazybitsstudios.com/another-way-of-aligning-elements-when-creating-icons) as much as possible within the guidelines. The visual center is where your icon looks and feels centered.
3. Avoid noticable black spots by reducing the stroke width or simplifying the icons.
4. Avoid close distances between strokes. The icons on the phone screen will be smaller, so the small distances between the strokes will stick together.
5. Avoid drastic changes in stroke widths. When the strokes next to each other differ in width by 4px or more, the icon will look sloppy.
- [ ] Approved by the Lawnicons reviewer
4 changes: 1 addition & 3 deletions .github/workflows/build_release_apk.yml
Original file line number Diff line number Diff line change
@@ -1,10 +1,8 @@
# TODO: Add signing key and build app bundle
name: Build release APK

on:
workflow_dispatch:
push:
branches:
- main

jobs:
build-release-apk:
Expand Down
20 changes: 20 additions & 0 deletions .idea/vcs.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@ For additional information on designing icons and samples, see [the Lawnicons Fi
Need help? [Join Lawnchair on Discord](https://discord.com/invite/3x8qNWxgGZ).

### TL;DR on icon design

> [!NOTE]
> Upload no more than 10 icons at a time, because reviewers only have time for small pull requests.
The canvas is `192×192px`. The content area for most icons is `160×160px`, meaning the long side of an icon should be `160px`. Square icons should be `154×154px`. No fill, the stroke width is `12px`. All shapes should be black `#000` with rounded ends and joins. Round 90° angles by `6-32px`. Avoid noticable black spots, close distances between strokes, and drastic changes in stroke widths. Simplify details, but don't lose recognizability. Provide original and localized names, so the icons can be found.

To avoid rework, save time and understand the limitations of the guidelines, it is worth reading reviews (e.g., [+8 icons, +1 link, +4 updates](https://github.com/LawnchairLauncher/lawnicons/pull/1865)) and creating 5-10 icons in the first contribution.
Expand Down
Loading

0 comments on commit 0ea79ea

Please sign in to comment.