Feat/firebase authentication #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
entrolEC
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
작업 분류
작업 상세 내용
1. Auth 폴더
Auth 폴더 내에서 로그인 관련 코드를 작성할 수 있도록 구분하였습니다.
2. 로그인 컴포넌트
찬섭님의 캘린더 레이아웃을 참고하여 버튼 클릭에 따라 Query Params를 변경하여 login과 signup 컴포넌트를 표시할 수 있도록 하였습니다.
아직 임시방편이기 때문에 추후 변경될 필요가 있습니다.
3. Auth type 구분
login, signup, logged 세 가지로 type을 구분하였습니다.
개선 필요
로그인 완료 이후, 로그인이 되었음을 인지할 수 있도록 유저의 정보를 표시하는 등의 작업이 필요합니다.