Add new check_variable_links method #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add
check_variable_links(model, modeldata; [throw_on_error=true] [, expect_hostdep_varnames=["global.tforce"]]) -> links_ok::Bool
This checks that all Variables are linked correctly, by checking that there are no unexpected host-dependent non-state
Variables (ie unlinked Variables).
This should be called soon after 'create_model_from_config', so that an appropriate error is generated early in the user model script
if any variables are unlinked.
Remove the variable link check from 'check_ready', as that was too late to be useful (often a hard-to-interpret error to do with
Variable size or allocation had already happened).
See corresponding PR in PALEOmodel to add this check to PALEOmodel.initialize!
sjdaines
added a commit
to PALEOtoolkit/PALEOmodel.jl
that referenced
this pull request
Nov 27, 2024
initialize!() now calls new PALEOboxes.check_variable_links() early, so give a better error message and exit if there is a configuration error resulting in unlinked variables. NB: requires new PALEOboxes v0.21.31, with change in PALEOtoolkit/PALEOboxes.jl#138
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
This checks that all Variables are linked correctly, by checking that there are no unexpected host-dependent non-state Variables (ie unlinked Variables).
This should be called soon after 'create_model_from_config', so that an appropriate error is generated early in the user model script if any variables are unlinked.
Remove the variable link check from 'check_ready', as that was too late to be useful (often a hard-to-interpret error to do with Variable size or allocation was generated first).
See corresponding PR in PALEOmodel to add this check to PALEOmodel.initialize!