New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed and simplified swctl support command #137

Merged

fgschwan merged 2 commits into PANTHEONtech:main from fgschwan:swctl-support-fix

Oct 10, 2023

Collaborator

fgschwan commented Oct 10, 2023

Fixed calling of swctl support that was failing due to multiple reasons:

bad agentctl parameters ordering
not handled nil pointer usage in code -> applied quick fix and reduced report scope (see FIXME in code)

Also simplified error handling logic and reorganized reporting to maximize reporting capabilities in case of errors.


          fixed and simplified swctl support command

8f262b5

Signed-off-by: Filip Gschwandtner <[email protected]>

fgschwan requested review from pemoticak and Giluerre

October 10, 2023 12:05


          fixed bad error referencing

90d7924

Signed-off-by: Filip Gschwandtner <[email protected]>

pemoticak approved these changes

View reviewed changes

fgschwan merged commit 661c753 into PANTHEONtech:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet