swctl: config helper wrap 'agentctl --help' and merge with swctl #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Giluerre
commented
Oct 18, 2023
Giluerre
commented
- changing flags to args
- deciding which flags belong to agentctl and which to swctl, deciding in run function
- merging both flagset to one help
Giluerre
force-pushed
the
agentctl_config
branch
2 times, most recently
from
3a442da
to
ef08bfa
Compare
pemoticak
requested changes
Oct 20, 2023
There was a problem hiding this comment.
Additionally it would be nice if swctl config -h referenced swctl binary instead of agentctl. With this PR when running swctl config -h the usage line of the output mentions agentctl (Usage: agentctl config [options] COMMAND). This is not a very urgent matter though.
…lags' to it Signed-off-by: Daniel Béreš <[email protected]>
Signed-off-by: Daniel Béreš <[email protected]>
Giluerre
force-pushed
the
agentctl_config
branch
from
819b76a
to
d0226da
Compare
pemoticak
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.