Do not use input to set access-key #288
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous approach did not work because: -GHCR requires a PAT to push images, and publish-access-key which defaults to "default", is not a valid token. -secrets.MM_PKG_WRITE was not used in login step, instead it was only used in env. JIRA: LIGHTY-385 Signed-off-by: tobias.pobocik <[email protected]>
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
ihrasko
requested changes
Sep 12, 2025
| description: Should be this docker labeled with tag latest? Enter `true` if the tag `latest` should be added for image. | ||
| default: "true" | ||
| required: true | ||
| publish-access-key: |
There was a problem hiding this comment.
How are we going to select a tag to build?
ihrasko
requested changes
Sep 12, 2025
| shell: bash | ||
| run: | | ||
| echo ${{ inputs.publish-access-key}} | docker login --username ${{ github.actor }} --password-stdin ghcr.io | ||
| echo "${{ secrets.MM_PKG_WRITE }}" | docker login ghcr.io --username ${{ github.actor }} --password-stdin |
There was a problem hiding this comment.
What about to use https://github.com/docker/login-action?
jobs:
build-and-push:
runs-on: ubuntu-latest
steps:
- name: Checkout repository
uses: actions/checkout@v4
- name: Log in to GitHub Container Registry
uses: docker/login-action@v3
with:
registry: ghcr.io
username: ${{ github.actor }}
password: ${{ secrets.YOUR_PUBLISH_ACCESS_KEY }} # Use secrets context
# ... your docker build and push steps follow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous approach did not work because:
-GHCR requires a PAT to push images, and publish-access-key which defaults to "default", is not a valid token.
-secrets.MM_PKG_WRITE was not used in login step, instead it was only used in env.
JIRA: LIGHTY-385