Fix expanders for multiple modules #187
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ihrasko
requested changes
Jun 23, 2023
src/test/java/io/lighty/yang/validator/formats/JsonTreeTest.java
Outdated
Show resolved
Hide resolved
src/test/java/io/lighty/yang/validator/formats/JsonTreeTest.java
Outdated
Show resolved
Hide resolved
src/test/java/io/lighty/yang/validator/formats/JsonTreeTest.java
Outdated
Show resolved
Hide resolved
Tobianas
force-pushed
the
17.xFixv3
branch
2 times, most recently
from
7780688
to
5d7dd17
Compare
Previously, there was no test coverage for the output of multiple json-tree modules. To address this, this commit adds a new test that parses two modules and compares their combined output against the old expected output. This provides more comprehensive testing and ensures that the json-tree modules are correctly processing multiple inputs. JIRA:LIGHTY-229 Signed-off-by: tobias.pobocik <[email protected]>
Added test case for generating HTML file from multiple modules to identify the issue with multiple <body> tags. The test asserts that the file contains the expected modules, verifies that there is only one <body> tag, and checks if the output matches the expected HTML file. JIRA: LIGHTY-128 Signed-off-by: tobias.pobocik <[email protected]>
Ensure JsTree output contains a single body element, resolving the issue of multiple bodies in the generated HTML file. JIRA: LIGHTY-128 Signed-off-by: tobias.pobocik <[email protected]>
Since we have changed the logic of JsTree, the expected output for deviations needs to be changed. JIRA: LIGHTY-128 Signed-off-by: tobias.pobocik <[email protected]>
Expanders and collapsers were not funcional in the generated html file when using multiple modules. This patch resolves that issue JIRA: LIGHTY-229 Signed-off-by: tobias.pobocik <[email protected]>
Since we have changed the logic of JsTree, the expected output needs to be changed. JIRA: LIGHTY-229 Signed-off-by: tobias.pobocik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expanders and collapsers were not funcional in the generated
html file when using multiple modules. This patch resolves
that issue