-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix : add trigger pull_request #20
Conversation
@emibgo2 action ํ์ง๋์ด ์์ฑํด์ฃผ์ ๊ฒ์ด๊ธฐ ๋๋ฌธ์ |
before : ci/cd trggier git event.push after: create ci.yml create deploy.yml
ํ์ง๋ ๊ฒํ ํ์ |
.github/workflows/s3-deploy.yml
Outdated
on: | ||
push: | ||
branches: | ||
- main | ||
pull_request: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
์ด๋ถ๋ถ์ด pr ์ฌ๋ผ์์๋ actions์ด ์คํ๋๋๋ถ๋ถ์ด๊ตฐ์
@gbwlxhd97 ์ ๋ ํ์ธ ์๋ฃํ์์ต๋๋ค! @emibgo2 ์งํ๋ ๊ฒํ ํ ์ด์์์ผ๋ฉด ๋จธ์งํป๋ ๊ฒ๊ฐ์ต๋๋ค. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
๐ซ [์ง๋ผ ํฐ์ผ ๋ฒํธ] - ์์
์์ธ
์์ ์ ํ๋ ๋์ค ์ข ์ข pr์น์ธ ํ main ๋ธ๋์น์ ๋ณํฉ๋์์ง๋ง
์ค์ prod ํ๊ฒฝ์์ build ์คํจ ์๋ฌ๊ฐ ์ข ์ข ๊ฒ์ถ๋๊ณค ํฉ๋๋ค.
๋ฐ๋ผ์ main ๋ธ๋์น๋ก pull request์ผ๋ CI ๊ฒ์ฌ ํ
์คํจํ๋ฉด PR ์น์ธ์ ๋ถํ ํ์๊ณ
๊ทธ์ ๋ฐ๋ผ์ github Actionํ์ผ์ ๋ ๊ฐ๋ก ๋๋ด์ต๋๋ค.
trigger๋ฅผ main ๋ธ๋์น์ push, pull-request๋ก
pr์ํ๋ build์ ์ถํ lint,test code๊น์ง ํ์ธ ํ๋ ์ฉ๋์ธ ci.yml
prํ ๋ณํฉ์ํ๋ build ํ s3์ deployํ๋ ํ์์ผ๋ก ์์ ํ์ต๋๋ค.
๐๏ธ Note (optional)
main ๋ธ๋์น๋ก pull request์ผ๋ CI ๊ฒ์ฌ ํ
์คํจํ๋ฉด PR ์น์ธ์ ๋ถํ ํ์๊ณ
์ ๊ณผ์ ์
8.Create ๋ฒํผ์ ํด๋ฆญํ์ฌ ๊ท์น์ ์ ์ฅํฉ๋๋ค.
์ด๋ ๊ฒ ํ์ต๋๋ค!