JSONLD examples with working scripts. #53
Conversation
There was a problem hiding this comment.
@wolfiex great to see this starting to coalesce! With > 5000 file changes, not sure exactly how best to provide a "review" other than a couple of the tidbits that I have started to look at. Is there anything more specifically that I can do to provide feedback, and/or could be partition the review tasks across @taylor13, @matthew-mizielinski and myself - or even open this up to more to peruse at the WIP telco tomorrow?
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Compiling ld graphs institution and consortia update
institution action update consortium redesign moving unapproved consortiums to "forReview" updating consortia build script fix. generation of outputs in JSONLD/scripts/outputs symbolic link to ld compiled outputs adding new inst auto setting
|
@wolfiex looks like bulk progress is happening, exciting! |
This comment was marked as outdated.
This comment was marked as outdated.
removing cmip: from all types frequency, grid label and source-type fix node script fix Delete .github/libs/checks/__pycache__ directory Delete .github/libs/checks/.DS_Store Delete .github/libs/__pycache__ directory Update .gitignore adding consortia for cmip6plus miroc fix ncc id correction solaris-heppa id correction recompute ld cleanup json formatting script json formatting script json formatting script keysort and @id correction parse script fix dev work cvs native nominal realm correction
This comment was marked as outdated.
This comment was marked as outdated.
wolfiex
force-pushed
the
jsonld
branch
2 times, most recently
from
31ef961 to
8882475
Compare
There was a problem hiding this comment.
I believe the changes here are all confined to the JSONLD and .github actions directories.
As things stand this doesn't impact on the CMOR 3.x formatted mip tables nor does it alter the controlled vocabulary entries at the root of this repository.
From my testing with the CMIP-LD repository code this change supports the construction of the CVs for the CMIP6Plus repository, and I've been able to test the resulting CMIP6Plus_CVs.json file.
One item I did note in scanning over the files under JSONLD is the spelling of developement (change to development if possible).
converting to use cmipld action to update jsonld action to update jsonld jsonld automations jsonld automations
initial organisations framing script. initial organisations framing script.
frequency generation
generate resolution
|
Latest commits added to re-generate the main repository files - see commits above. These are identical in the diff, just with different 'version metadata' . The running of these scripts still needs to be incorporated into the action, but happy to merge in the meantime. |
update action to run all scripts on update
|
Resolved changes suggested by @durack1 |
|
I'm happy to press that big green button if you want me to! This is great, almost there.. |
LD repository: