Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x86/FPU: Always preserve sign in neg.s (Fix GT4 text) #10464

Merged
merged 2 commits into from
Dec 28, 2023
Merged

x86/FPU: Always preserve sign in neg.s (Fix GT4 text) #10464

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
601f1d7
x86/FPU: Always preserve sign in neg.s
stenzek Dec 24, 2023
1d2ef4f
GameDB: Remove mention of full clamp for GT4
stenzek Dec 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 0 additions & 22 deletions bin/resources/GameIndex.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,7 +314,6 @@ PAPX-90512:
region: "NTSC-J"
clampModes:
vuClampMode: 2 # Text in GT mode works.
# eeClampMode = 3 Text in races works.
gsHWFixes:
mipmap: 2 # Mipmap + trilinear, improves ground textures to match sw renderer.
trilinearFiltering: 1
Expand Down Expand Up @@ -523,7 +522,6 @@ PBPX-95523:
trilinearFiltering: 1
halfPixelOffset: 4 # Fixes weird edge shadows and depth bleed which happens on the edge as well.
getSkipCount: "GSC_PolyphonyDigitalGames" # Fixes post processing.
# eeClampMode = 3 Text in races works.
# vuClampMode = 2 Text in GT mode works.
PBPX-95524:
name: "Gran Turismo 4 - Prologue [PlayStation 2 Racing Pack]"
Expand All @@ -534,7 +532,6 @@ PBPX-95524:
trilinearFiltering: 1
halfPixelOffset: 4 # Fixes weird edge shadows and depth bleed which happens on the edge as well.
getSkipCount: "GSC_PolyphonyDigitalGames" # Fixes post processing.
# eeClampMode = 3 Text in races works.
# vuClampMode = 2 Text in GT mode works.
PBPX-95525:
name: "Final Fantasy XII"
Expand All @@ -561,7 +558,6 @@ PBPX-95601:
- "SCPS-19304"
- "SCPS-15009"
- "SCPS-55007"
# eeClampMode = 3 Text in races works.
PCPX-96301:
name: "I.Q Remix+ - Intelligent Qube"
region: "NTSC-J"
Expand Down Expand Up @@ -767,7 +763,6 @@ PCPX-96649:
trilinearFiltering: 1
halfPixelOffset: 4 # Fixes weird edge shadows and depth bleed which happens on the edge as well.
getSkipCount: "GSC_PolyphonyDigitalGames" # Fixes post processing.
# eeClampMode = 3 Text in races works.
PCPX-96653:
name: "Ratchet & Clank 3"
region: "NTSC-J"
Expand Down Expand Up @@ -1176,7 +1171,6 @@ SCAJ-20066:
- "SCPS-19304"
- "SCPS-15009"
- "SCPS-55007"
# eeClampMode = 3 Text in races works.
# vuClampMode = 2 Text in GT mode works.
SCAJ-20067:
name: "GunGrave O.D."
Expand Down Expand Up @@ -2051,14 +2045,12 @@ SCAJ-30006:
- "SCPS-19304"
- "SCPS-15009"
- "SCPS-55007"
# eeClampMode = 3 Text in races works.
SCAJ-30007:
name: "Gran Turismo 4"
region: "NTSC-Unk"
compat: 5
clampModes:
vuClampMode: 2 # Text in GT mode works.
# eeClampMode = 3 Text in races works.
gsHWFixes:
mipmap: 2 # Mipmap + trilinear, improves ground textures to match sw renderer.
trilinearFiltering: 1
Expand All @@ -2069,7 +2061,6 @@ SCAJ-30008:
region: "NTSC-Unk"
clampModes:
vuClampMode: 2 # Text in GT mode works.
# eeClampMode = 3 Text in races works.
gsHWFixes:
mipmap: 2 # Mipmap + trilinear, improves ground textures to match sw renderer.
trilinearFiltering: 1
Expand Down Expand Up @@ -3135,7 +3126,6 @@ SCED-52455:
trilinearFiltering: 1
halfPixelOffset: 4 # Fixes weird edge shadows and depth bleed which happens on the edge as well.
getSkipCount: "GSC_PolyphonyDigitalGames" # Fixes post processing.
# eeClampMode = 3 Text in races works.
# vuClampMode = 2 Text in GT mode works.
SCED-52461:
name: "SingStar [Press Kit]"
Expand Down Expand Up @@ -4675,7 +4665,6 @@ SCES-51719:
compat: 5
clampModes:
vuClampMode: 2 # Text in GT mode works.
# eeClampMode = 3 Text in races works.
gsHWFixes:
mipmap: 2 # Mipmap + trilinear, improves ground textures to match sw renderer.
trilinearFiltering: 1
Expand Down Expand Up @@ -4923,7 +4912,6 @@ SCES-52438:
- "SCES-51719"
- "SCES-52438"
- "SCES-50294"
# eeClampMode = 3 Text in races works.
# vuClampMode = 2 Text in GT mode works.
SCES-52456:
name: "Ratchet & Clank 3"
Expand Down Expand Up @@ -6333,7 +6321,6 @@ SCKA-20022:
trilinearFiltering: 1
halfPixelOffset: 4 # Fixes weird edge shadows and depth bleed which happens on the edge as well.
getSkipCount: "GSC_PolyphonyDigitalGames" # Fixes post processing.
# eeClampMode = 3 Text in races works.
# vuClampMode = 2 Text in GT mode works.
SCKA-20023:
name: "Fatal Frame II"
Expand Down Expand Up @@ -6961,7 +6948,6 @@ SCKA-30001:
region: "NTSC-K"
clampModes:
vuClampMode: 2 # Text in GT mode works.
# eeClampMode = 3 Text in races works.
gsHWFixes:
mipmap: 2 # Mipmap + trilinear, improves ground textures to match sw renderer.
trilinearFiltering: 1
Expand Down Expand Up @@ -7645,7 +7631,6 @@ SCPS-15055:
- "SCPS-19304"
- "SCPS-15009"
- "SCPS-55007"
# eeClampMode = 3 Text in races works.
# vuClampMode = 2 Text in GT mode works.
SCPS-15056:
name: ラチェット＆クランク2 ガガガ！銀河のコマンドーっす
Expand Down Expand Up @@ -8212,7 +8197,6 @@ SCPS-17001:
compat: 5
clampModes:
vuClampMode: 2 # Text in GT mode works.
# eeClampMode = 3 Text in races works.
gsHWFixes:
mipmap: 2 # Mipmap + trilinear, improves ground textures to match sw renderer.
trilinearFiltering: 1
Expand Down Expand Up @@ -8466,7 +8450,6 @@ SCPS-19252:
region: "NTSC-J"
clampModes:
vuClampMode: 2 # Text in GT mode works.
# eeClampMode = 3 Text in races works.
gsHWFixes:
mipmap: 2 # Mipmap + trilinear, improves ground textures to match sw renderer.
trilinearFiltering: 1
Expand Down Expand Up @@ -8541,7 +8524,6 @@ SCPS-19304:
- "SCPS-15009"
- "SCPS-55007"
# vuClampMode = 2 Text in GT mode works.
# eeClampMode = 3 Text in races works.
SCPS-19305:
name: SIREN PS2 the Best
name-sort: SIREN PS2 the Best
Expand Down Expand Up @@ -9299,7 +9281,6 @@ SCUS-90682:
region: "NTSC-U"
clampModes:
vuClampMode: 2 # Text in GT mode works.
# eeClampMode = 3 Text in races works.
gsHWFixes:
mipmap: 2 # Mipmap + trilinear, improves ground textures to match sw renderer.
trilinearFiltering: 1
Expand Down Expand Up @@ -10109,7 +10090,6 @@ SCUS-97328:
compat: 5
clampModes:
vuClampMode: 2 # Text in GT mode works.
# eeClampMode = 3 Text in races works.
gsHWFixes:
mipmap: 2 # Mipmap + trilinear, improves ground textures to match sw renderer.
trilinearFiltering: 1
Expand Down Expand Up @@ -10503,7 +10483,6 @@ SCUS-97436:
region: "NTSC-U"
clampModes:
vuClampMode: 2 # Text in GT mode works.
# eeClampMode = 3 Text in races works.
gsHWFixes:
mipmap: 2 # Mipmap + trilinear, improves ground textures to match sw renderer.
trilinearFiltering: 1
Expand Down Expand Up @@ -10721,7 +10700,6 @@ SCUS-97483:
region: "NTSC-U"
clampModes:
vuClampMode: 2 # Text in GT mode works.
# eeClampMode = 3 Text in races works.
gsHWFixes:
mipmap: 2 # Mipmap + trilinear, improves ground textures to match sw renderer.
trilinearFiltering: 1
Expand Down
5 changes: 4 additions & 1 deletion pcsx2/x86/iFPU.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1669,7 +1669,10 @@ void recNEG_S_xmm(int info)

//xAND(ptr32[&fpuRegs.fprc[31]], ~(FPUflagO|FPUflagU)); // Clear O and U flags
xXOR.PS(xRegisterSSE(EEREC_D), ptr[&s_neg[0]]);
ClampValues(EEREC_D);

// Always preserve sign. Using float clamping here would result in
// +inf to become +fMax instead of -fMax, which is definitely wrong.
fpuFloat3(EEREC_D);
}

FPURECOMPILE_CONSTCODE(NEG_S, XMMINFO_WRITED | XMMINFO_READS);
Expand Down