Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove wrong pnach #272

Merged
merged 1 commit into from
Dec 26, 2023
Merged

Remove wrong pnach #272

merged 1 commit into from
Dec 26, 2023

Conversation

Berylskid
Copy link
Contributor

Just removed SLUS-20910_5D0244D3.pnach from wrong directory.

@Daniel-McCarthy
Copy link
Contributor

Just for added context for convenience:
This PR #248 added this file to the root folder accidentally, and this PR #265 copied the patch into /patches/ folder but didn't delete the copy left in the root folder.

Figured I'd add this as a note since I had checked into why this was here and if there was a version where it was supposed to be as well. LGTM!

Daniel-McCarthy
Daniel-McCarthy approved these changes Dec 24, 2023
View reviewed changes
Copy link
Contributor

@Daniel-McCarthy Daniel-McCarthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Verified that the file being removed also exists in /patches/ and that the file contents are identical so nothing is lost. 👍

@refractionpcsx2 refractionpcsx2 merged commit 57da45c into PCSX2:main Dec 26, 2023
2 checks passed
@Berylskid Berylskid deleted the remove-mistake branch December 26, 2023 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Daniel-McCarthy Daniel-McCarthy Daniel-McCarthy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Berylskid @Daniel-McCarthy @refractionpcsx2