use permissive PDL::Type->new not string-eval

PDLPorters · Nov 10, 2024 · 79012e1 · 79012e1
1 parent e64795c
commit 79012e1
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/Basic/IO-Storable/storable.pd b/Basic/IO-Storable/storable.pd
@@ -180,7 +180,8 @@ sub pdlunpack {
     my ($typestring) = unpack( 'A16', substr( $pack, $offset ) );
     $offset += 16;
 
-    $type = eval( '$PDL::Types::' . $typestring );
+    $typestring =~ s#\s+$##;
+    $type = eval { PDL::Type->new($typestring)->enum };
     if( $@ )
     {
       croak "PDL::IO::Storable couldn't parse type string '$typestring'. Giving up";
@@ -224,8 +225,6 @@ sub pdlunpack {
       $do_swap = 1;
     }
 
-
-
     # mostly this acts like unpack('Q<'...), but works even if my unpack()
     # doesn't support 'Q'. This also makes sure that my PDL_Indx is large enough
     # to read this ndarray