Fix accessing preequilibrationConditionId without checking for presen…

…ce (#228) Fixes a bug in petab.visualize.data_overview.create_report which fails if there is no preequilibrationConditionId column in the measurements table.
PEtab-dev · Oct 17, 2023 · 62d5ca8 · 62d5ca8
1 parent 2c44efe
commit 62d5ca8
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/petab/visualize/data_overview.py b/petab/visualize/data_overview.py
@@ -61,13 +61,14 @@ def get_data_per_observable(measurement_df: pd.DataFrame) -> pd.DataFrame:
     """
 
     my_measurements = measurement_df.copy()
-    my_measurements[PREEQUILIBRATION_CONDITION_ID] = my_measurements[
-        PREEQUILIBRATION_CONDITION_ID
-    ].astype("object")
 
     index = [SIMULATION_CONDITION_ID]
     if PREEQUILIBRATION_CONDITION_ID in my_measurements:
-        my_measurements[PREEQUILIBRATION_CONDITION_ID].fillna("", inplace=True)
+        my_measurements[PREEQUILIBRATION_CONDITION_ID] = (
+            my_measurements[PREEQUILIBRATION_CONDITION_ID]
+            .astype("object")
+            .fillna("", inplace=True)
+        )
         index.append(PREEQUILIBRATION_CONDITION_ID)
 
     data_per_observable = pd.pivot_table(