Add constants + I/O + validation for new conditions/experiments tables #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #334 +/- ##
===========================================
+ Coverage 74.26% 74.36% +0.10%
===========================================
Files 52 53 +1
Lines 5048 5138 +90
Branches 888 903 +15
===========================================
+ Hits 3749 3821 +72
- Misses 962 977 +15
- Partials 337 340 +3 ☔ View full report in Codecov by Sentry. |
dweindl
force-pushed
the
experiment_constants_io
branch
5 times, most recently
from
d0443e3 to
7dd3e41
Compare
dweindl
changed the title
dweindl
force-pushed
the
experiment_constants_io
branch
from
7dd3e41 to
f9a285c
Compare
* constants * read/write experiment table * add experiments table to Problem, and populate from yaml * some first validation tasks To be complemented by separate pull requests.
dweindl
force-pushed
the
experiment_constants_io
branch
from
f9a285c to
f18f1f6
Compare
dweindl
added a commit
that referenced
this pull request
Dec 18, 2024
Add basic support for PEtab version 2 experiments (see also PEtab-dev/PEtab#586, and PEtab-dev/PEtab#581). Follow-up to #334. Partially supersedes #263, which was started before petab.v1/petab.v2 were introduced and before PEtab-dev/PEtab#586. * updates the required fields in the measurement table * updates some validation functions to not expect the old `simulationConditionId`s (but does not do full validation yet) * extends PEtab v1 up-conversion to create a new experiment table. --------- Co-authored-by: Dilan Pathirana <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to PEtab-dev/PEtab#586
To be complemented by separate pull requests.